A column-span:all element should always establish a new formatting context.

This also applies when the element isn't contained by a multicol container (which means that we shouldn't require the spanner placeholder to be present). BUG=709362 Review-Url: https://codereview.chromium.org/2799363003 Cr-Commit-Position: refs/heads/master@{#462865}

A column-span:all element should always establish a new formatting context.
This also applies when the element isn't contained by a multicol container (which means that we shouldn't require the spanner placeholder to be present). BUG=709362 Review-Url: https://codereview.chromium.org/2799363003 Cr-Commit-Position: refs/heads/master@{#462865}
1c9b66ff · mstensho · Commit bot · 825abe65 · 1c9b66ff · 1c9b66ff
Commit 1c9b66ff authored Apr 07, 2017 by mstensho Committed by Commit bot Apr 07, 2017
3 changed files
--- a/third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html
+++ b/third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html
+<!DOCTYPE html>
+<p>There should be a green square below.</p>
+<div style="position:relative;">
+    <div style="float:left; width:50px; height:100px; background:green;"></div>
+    <div id="invalidSpanner" style="column-span:all; width:50px; background:green;">
+        <div style="float:left; width:50px; height:100px;"></div>
+    </div>
+</div>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+<script>
+    test(function() {
+	var invalidSpanner = document.getElementById("invalidSpanner");
+        // It should not overlap with floats in the same block formatting
+        // context.
+        assert_equals(invalidSpanner.offsetLeft, 50);
+	// It should establish a new block formatting context, so that it
+	// stretches to contain all floats inside.
+        assert_equals(invalidSpanner.offsetHeight, 100);
+    }, "Column spanner without ancestor multicol");
+</script>
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -559,7 +559,8 @@ bool LayoutBlock::createsNewFormattingContext() const {
         hasOverflowClip() || isFlexItemIncludingDeprecated() ||
         style()->specifiesColumns() || isLayoutFlowThread() || isTableCell() ||
         isTableCaption() || isFieldset() || isWritingModeRoot() ||
-         isDocumentElement() || isColumnSpanAll() || isGridItem() ||
+         isDocumentElement() || isGridItem() ||
+         style()->getColumnSpan() == ColumnSpanAll ||
         style()->containsPaint() || style()->containsLayout() ||
         isSVGForeignObject() || style()->display() == EDisplay::kFlowRoot;
 }

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4761,6 +4761,7 @@ bool LayoutBox::avoidsFloats() const {
  // crbug.com/460704: This should be merged with createsNewFormattingContext().
  return shouldBeConsideredAsReplaced() || hasOverflowClip() || isHR() ||
         isLegend() || isWritingModeRoot() || isFlexItemIncludingDeprecated() ||
+         style()->getColumnSpan() == ColumnSpanAll ||
         style()->containsPaint() || style()->containsLayout() ||
         style()->display() == EDisplay::kFlowRoot;
 }