Commit 1c9b68fa authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Commit Bot

Android: Fix fullscreen/PIP mode bug

PIP Controller was handling a fullscreen event incorrectly. This CL
fixes by dismissing the activity at fullscreen exit (not entering).

Bug: 1048522
Change-Id: I0ae9d5424a6aed1ae66457b81ab79d5864eff2a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059028Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744523}
parent 405b6222
...@@ -26,7 +26,6 @@ import org.chromium.base.metrics.RecordHistogram; ...@@ -26,7 +26,6 @@ import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.flags.ChromeFeatureList; import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager.FullscreenListener; import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager.FullscreenListener;
import org.chromium.chrome.browser.fullscreen.FullscreenOptions;
import org.chromium.chrome.browser.infobar.InfoBarContainer; import org.chromium.chrome.browser.infobar.InfoBarContainer;
import org.chromium.chrome.browser.tab.EmptyTabObserver; import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
...@@ -219,7 +218,7 @@ public class PictureInPictureController { ...@@ -219,7 +218,7 @@ public class PictureInPictureController {
final TabModelSelector tabModelSelector = TabModelSelector.from(activityTab); final TabModelSelector tabModelSelector = TabModelSelector.from(activityTab);
final FullscreenListener fullscreenListener = new FullscreenListener() { final FullscreenListener fullscreenListener = new FullscreenListener() {
@Override @Override
public void onEnterFullscreen(Tab tab, FullscreenOptions options) { public void onExitFullscreen(Tab tab) {
dismissActivity(activity, METRICS_END_REASON_LEFT_FULLSCREEN); dismissActivity(activity, METRICS_END_REASON_LEFT_FULLSCREEN);
} }
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment