Commit 1ca17c55 authored by Caleb Rouleau's avatar Caleb Rouleau Committed by Commit Bot

[ChromeDriver] Check for Chrome crashes after 1 second rather than 60 seconds

Bug: 864205
Change-Id: I5d9ad26b1f14ae28ca1b80399539dbb3c3a978ee
Reviewed-on: https://chromium-review.googlesource.com/1141163Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576227}
parent 6da1f51d
...@@ -198,6 +198,7 @@ Status WaitForDevToolsAndCheckVersion( ...@@ -198,6 +198,7 @@ Status WaitForDevToolsAndCheckVersion(
URLRequestContextGetter* context_getter, URLRequestContextGetter* context_getter,
const SyncWebSocketFactory& socket_factory, const SyncWebSocketFactory& socket_factory,
const Capabilities* capabilities, const Capabilities* capabilities,
int wait_time,
std::unique_ptr<DevToolsHttpClient>* user_client) { std::unique_ptr<DevToolsHttpClient>* user_client) {
std::unique_ptr<DeviceMetrics> device_metrics; std::unique_ptr<DeviceMetrics> device_metrics;
if (capabilities && capabilities->device_metrics) if (capabilities && capabilities->device_metrics)
...@@ -215,7 +216,7 @@ Status WaitForDevToolsAndCheckVersion( ...@@ -215,7 +216,7 @@ Status WaitForDevToolsAndCheckVersion(
address, context_getter, socket_factory, std::move(device_metrics), address, context_getter, socket_factory, std::move(device_metrics),
std::move(window_types), capabilities->page_load_strategy)); std::move(window_types), capabilities->page_load_strategy));
base::TimeTicks deadline = base::TimeTicks deadline =
base::TimeTicks::Now() + base::TimeDelta::FromSeconds(60); base::TimeTicks::Now() + base::TimeDelta::FromSeconds(wait_time);
Status status = client->Init(deadline - base::TimeTicks::Now()); Status status = client->Init(deadline - base::TimeTicks::Now());
if (status.IsError()) if (status.IsError())
return status; return status;
...@@ -309,7 +310,7 @@ Status LaunchRemoteChromeSession( ...@@ -309,7 +310,7 @@ Status LaunchRemoteChromeSession(
std::unique_ptr<DevToolsHttpClient> devtools_http_client; std::unique_ptr<DevToolsHttpClient> devtools_http_client;
status = WaitForDevToolsAndCheckVersion( status = WaitForDevToolsAndCheckVersion(
capabilities.debugger_address, context_getter, socket_factory, capabilities.debugger_address, context_getter, socket_factory,
&capabilities, &devtools_http_client); &capabilities, 60, &devtools_http_client);
if (status.IsError()) { if (status.IsError()) {
return Status(kUnknownError, "cannot connect to chrome at " + return Status(kUnknownError, "cannot connect to chrome at " +
capabilities.debugger_address.ToString(), capabilities.debugger_address.ToString(),
...@@ -445,7 +446,7 @@ Status LaunchDesktopChrome(URLRequestContextGetter* context_getter, ...@@ -445,7 +446,7 @@ Status LaunchDesktopChrome(URLRequestContextGetter* context_getter,
if (status.IsOk()) { if (status.IsOk()) {
status = WaitForDevToolsAndCheckVersion( status = WaitForDevToolsAndCheckVersion(
NetAddress(devtools_port), context_getter, socket_factory, NetAddress(devtools_port), context_getter, socket_factory,
&capabilities, &devtools_http_client); &capabilities, 1, &devtools_http_client);
} }
if (status.IsOk()) { if (status.IsOk()) {
break; break;
...@@ -563,9 +564,9 @@ Status LaunchAndroidChrome(URLRequestContextGetter* context_getter, ...@@ -563,9 +564,9 @@ Status LaunchAndroidChrome(URLRequestContextGetter* context_getter,
} }
std::unique_ptr<DevToolsHttpClient> devtools_http_client; std::unique_ptr<DevToolsHttpClient> devtools_http_client;
status = WaitForDevToolsAndCheckVersion(NetAddress(devtools_port), status = WaitForDevToolsAndCheckVersion(
context_getter, socket_factory, NetAddress(devtools_port), context_getter, socket_factory, &capabilities,
&capabilities, &devtools_http_client); 60, &devtools_http_client);
if (status.IsError()) { if (status.IsError()) {
device->TearDown(); device->TearDown();
return status; return status;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment