Inline Create() in element_factory.cc.tmpl 2/3

This CL removes `inline` specifiers from constructors in core/html
classes to prepare for porting
third_party/blink/renderer/build/scripts/templates/element_factory.cc.tmpl
to MakeGarbageCollected.

Bug: 939691
Change-Id: Ic6ccd6ad5f38382453ae11d19720ae7012061659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578546Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#653567}

third_party/blink/renderer/core/html/canvas/html_canvas_element.cc

@@ -123,7 +123,7 @@ constexpr int kUndefinedQualityValue = -1.0;
 
 }  // namespace
 
-inline HTMLCanvasElement::HTMLCanvasElement(Document& document)
+HTMLCanvasElement::HTMLCanvasElement(Document& document)
     : HTMLElement(kCanvasTag, document),
       ContextLifecycleObserver(&document),
       PageVisibilityObserver(document.GetPage()),

third_party/blink/renderer/core/html/forms/html_button_element.cc

@@ -37,7 +37,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLButtonElement::HTMLButtonElement(Document& document)
+HTMLButtonElement::HTMLButtonElement(Document& document)
     : HTMLFormControlElement(kButtonTag, document),
       type_(SUBMIT),
       is_activated_submit_(false) {}

third_party/blink/renderer/core/html/forms/html_data_list_element.cc

@@ -39,7 +39,7 @@
 
 namespace blink {
 
-inline HTMLDataListElement::HTMLDataListElement(Document& document)
+HTMLDataListElement::HTMLDataListElement(Document& document)
     : HTMLElement(html_names::kDatalistTag, document) {}
 
 HTMLDataListElement* HTMLDataListElement::Create(Document& document) {

third_party/blink/renderer/core/html/forms/html_field_set_element.cc

@@ -40,7 +40,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLFieldSetElement::HTMLFieldSetElement(Document& document)
+HTMLFieldSetElement::HTMLFieldSetElement(Document& document)
     : HTMLFormControlElement(kFieldsetTag, document) {}
 
 HTMLFieldSetElement* HTMLFieldSetElement::Create(Document& document) {

third_party/blink/renderer/core/html/forms/html_legend_element.cc

@@ -32,7 +32,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLLegendElement::HTMLLegendElement(Document& document)
+HTMLLegendElement::HTMLLegendElement(Document& document)
     : HTMLElement(kLegendTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLLegendElement)

third_party/blink/renderer/core/html/forms/html_opt_group_element.cc

@@ -39,7 +39,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLOptGroupElement::HTMLOptGroupElement(Document& document)
+HTMLOptGroupElement::HTMLOptGroupElement(Document& document)
     : HTMLElement(kOptgroupTag, document) {}
 
 // An explicit empty destructor should be in html_opt_group_element.cc, because

third_party/blink/renderer/core/html/html_area_element.cc

@@ -44,7 +44,7 @@ float ClampCoordinate(double value) {
 
 using namespace html_names;
 
-inline HTMLAreaElement::HTMLAreaElement(Document& document)
+HTMLAreaElement::HTMLAreaElement(Document& document)
     : HTMLAnchorElement(kAreaTag, document), shape_(kRect) {}
 
 // An explicit empty destructor should be in html_area_element.cc, because

third_party/blink/renderer/core/html/html_content_element.cc

@@ -40,7 +40,7 @@ using namespace html_names;
 
 DEFINE_NODE_FACTORY(HTMLContentElement)
 
-inline HTMLContentElement::HTMLContentElement(Document& document)
+HTMLContentElement::HTMLContentElement(Document& document)
     : V0InsertionPoint(kContentTag, document),
       should_parse_select_(false),
       is_valid_selector_(true) {

third_party/blink/renderer/core/html/html_dialog_element.cc

@@ -95,7 +95,7 @@ static void InertSubtreesChanged(Document& document) {
   document.ClearAXObjectCache();
 }
 
-inline HTMLDialogElement::HTMLDialogElement(Document& document)
+HTMLDialogElement::HTMLDialogElement(Document& document)
     : HTMLElement(kDialogTag, document),
       centering_mode_(kNotCentered),
       centered_position_(0),

third_party/blink/renderer/core/html/html_directory_element.cc

@@ -28,7 +28,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLDirectoryElement::HTMLDirectoryElement(Document& document)
+HTMLDirectoryElement::HTMLDirectoryElement(Document& document)
     : HTMLElement(kDirTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLDirectoryElement)

third_party/blink/renderer/core/html/html_dlist_element.cc

@@ -28,7 +28,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLDListElement::HTMLDListElement(Document& document)
+HTMLDListElement::HTMLDListElement(Document& document)
     : HTMLElement(kDlTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLDListElement)

third_party/blink/renderer/core/html/html_embed_element.cc

@@ -42,8 +42,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLEmbedElement::HTMLEmbedElement(Document& document,
-                                          const CreateElementFlags flags)
+HTMLEmbedElement::HTMLEmbedElement(Document& document,
+                                   const CreateElementFlags flags)
     : HTMLPlugInElement(kEmbedTag,
                         document,
                         flags,

third_party/blink/renderer/core/html/html_frame_set_element.cc

@@ -41,7 +41,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLFrameSetElement::HTMLFrameSetElement(Document& document)
+HTMLFrameSetElement::HTMLFrameSetElement(Document& document)
     : HTMLElement(kFramesetTag, document),
       border_(6),
       border_set_(false),

third_party/blink/renderer/core/html/html_heading_element.cc

@@ -24,8 +24,8 @@
 
 namespace blink {
 
-inline HTMLHeadingElement::HTMLHeadingElement(const QualifiedName& tag_name,
-                                              Document& document)
+HTMLHeadingElement::HTMLHeadingElement(const QualifiedName& tag_name,
+                                       Document& document)
     : HTMLElement(tag_name, document) {}
 
 DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLHeadingElement)

third_party/blink/renderer/core/html/html_map_element.cc

@@ -35,7 +35,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLMapElement::HTMLMapElement(Document& document)
+HTMLMapElement::HTMLMapElement(Document& document)
     : HTMLElement(kMapTag, document) {
   UseCounter::Count(document, WebFeature::kMapElement);
 }

third_party/blink/renderer/core/html/html_marquee_element.cc

@@ -51,7 +51,7 @@
 
 namespace blink {
 
-inline HTMLMarqueeElement::HTMLMarqueeElement(Document& document)
+HTMLMarqueeElement::HTMLMarqueeElement(Document& document)
     : HTMLElement(html_names::kMarqueeTag, document) {
   UseCounter::Count(document, WebFeature::kHTMLMarqueeElement);
 }

third_party/blink/renderer/core/html/html_menu_element.cc

@@ -28,7 +28,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLMenuElement::HTMLMenuElement(Document& document)
+HTMLMenuElement::HTMLMenuElement(Document& document)
     : HTMLElement(kMenuTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLMenuElement)

third_party/blink/renderer/core/html/html_mod_element.cc

@@ -28,8 +28,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLModElement::HTMLModElement(const QualifiedName& tag_name,
-                                      Document& document)
+HTMLModElement::HTMLModElement(const QualifiedName& tag_name,
+                               Document& document)
     : HTMLElement(tag_name, document) {}
 
 DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLModElement)

third_party/blink/renderer/core/html/html_no_embed_element.cc

@@ -39,7 +39,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLNoEmbedElement::HTMLNoEmbedElement(Document& document)
+HTMLNoEmbedElement::HTMLNoEmbedElement(Document& document)
     : HTMLElement(kNoembedTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLNoEmbedElement)

third_party/blink/renderer/core/html/html_no_script_element.cc

@@ -39,7 +39,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLNoScriptElement::HTMLNoScriptElement(Document& document)
+HTMLNoScriptElement::HTMLNoScriptElement(Document& document)
     : HTMLElement(kNoscriptTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLNoScriptElement)

third_party/blink/renderer/core/html/html_object_element.cc

@@ -48,8 +48,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLObjectElement::HTMLObjectElement(Document& document,
-                                            const CreateElementFlags flags)
+HTMLObjectElement::HTMLObjectElement(Document& document,
+                                     const CreateElementFlags flags)
     : HTMLPlugInElement(kObjectTag,
                         document,
                         flags,

third_party/blink/renderer/core/html/html_olist_element.cc

@@ -34,7 +34,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLOListElement::HTMLOListElement(Document& document)
+HTMLOListElement::HTMLOListElement(Document& document)
     : HTMLElement(kOlTag, document),
       start_(0xBADBEEF),
       item_count_(0),

third_party/blink/renderer/core/html/html_param_element.cc

@@ -30,7 +30,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLParamElement::HTMLParamElement(Document& document)
+HTMLParamElement::HTMLParamElement(Document& document)
     : HTMLElement(kParamTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLParamElement)

third_party/blink/renderer/core/html/html_picture_element.cc

@@ -15,7 +15,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLPictureElement::HTMLPictureElement(Document& document)
+HTMLPictureElement::HTMLPictureElement(Document& document)
     : HTMLElement(kPictureTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLPictureElement)

third_party/blink/renderer/core/html/html_pre_element.cc

@@ -31,8 +31,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLPreElement::HTMLPreElement(const QualifiedName& tag_name,
-                                      Document& document)
+HTMLPreElement::HTMLPreElement(const QualifiedName& tag_name,
+                               Document& document)
     : HTMLElement(tag_name, document) {}
 
 DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLPreElement)

third_party/blink/renderer/core/html/html_quote_element.cc

@@ -29,8 +29,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLQuoteElement::HTMLQuoteElement(const QualifiedName& tag_name,
-                                          Document& document)
+HTMLQuoteElement::HTMLQuoteElement(const QualifiedName& tag_name,
+                                   Document& document)
     : HTMLElement(tag_name, document) {
   DCHECK(HasTagName(kQTag) || HasTagName(kBlockquoteTag));
 }

third_party/blink/renderer/core/html/html_rt_element.cc

@@ -11,7 +11,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLRTElement::HTMLRTElement(Document& document)
+HTMLRTElement::HTMLRTElement(Document& document)
     : HTMLElement(kRtTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLRTElement)

third_party/blink/renderer/core/html/html_ruby_element.cc

@@ -11,7 +11,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLRubyElement::HTMLRubyElement(Document& document)
+HTMLRubyElement::HTMLRubyElement(Document& document)
     : HTMLElement(kRubyTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLRubyElement)

third_party/blink/renderer/core/html/html_shadow_element.cc

@@ -40,7 +40,7 @@ namespace blink {
 
 class Document;
 
-inline HTMLShadowElement::HTMLShadowElement(Document& document)
+HTMLShadowElement::HTMLShadowElement(Document& document)
     : V0InsertionPoint(html_names::kShadowTag, document) {
   UseCounter::Count(document, WebFeature::kHTMLShadowElement);
 }

third_party/blink/renderer/core/html/html_slot_element.cc

@@ -75,7 +75,7 @@ HTMLSlotElement* HTMLSlotElement::CreateUserAgentCustomAssignSlot(
   return slot;
 }
 
-inline HTMLSlotElement::HTMLSlotElement(Document& document)
+HTMLSlotElement::HTMLSlotElement(Document& document)
     : HTMLElement(kSlotTag, document) {
   UseCounter::Count(document, WebFeature::kHTMLSlotElement);
   SetHasCustomStyleCallbacks();

third_party/blink/renderer/core/html/html_table_col_element.cc

@@ -37,8 +37,8 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLTableColElement::HTMLTableColElement(const QualifiedName& tag_name,
-                                                Document& document)
+HTMLTableColElement::HTMLTableColElement(const QualifiedName& tag_name,
+                                         Document& document)
     : HTMLTablePartElement(tag_name, document), span_(kDefaultColSpan) {}
 
 DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLTableColElement)

third_party/blink/renderer/core/html/html_template_element.cc

@@ -39,7 +39,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLTemplateElement::HTMLTemplateElement(Document& document)
+HTMLTemplateElement::HTMLTemplateElement(Document& document)
     : HTMLElement(kTemplateTag, document) {
   UseCounter::Count(document, WebFeature::kHTMLTemplateElement);
 }

third_party/blink/renderer/core/html/html_wbr_element.cc

@@ -37,7 +37,7 @@ namespace blink {
 
 using namespace html_names;
 
-inline HTMLWBRElement::HTMLWBRElement(Document& document)
+HTMLWBRElement::HTMLWBRElement(Document& document)
     : HTMLElement(kWbrTag, document) {}
 
 DEFINE_NODE_FACTORY(HTMLWBRElement)

third_party/blink/renderer/core/html/media/html_video_element.cc

@@ -78,7 +78,7 @@ enum VideoPersistenceControlsType {
 
 }  // anonymous namespace
 
-inline HTMLVideoElement::HTMLVideoElement(Document& document)
+HTMLVideoElement::HTMLVideoElement(Document& document)
     : HTMLMediaElement(kVideoTag, document),
       remoting_interstitial_(nullptr),
       picture_in_picture_interstitial_(nullptr),

third_party/blink/renderer/core/html/track/html_track_element.cc

@@ -48,7 +48,7 @@ static String UrlForLoggingTrack(const KURL& url) {
   return url.GetString().Substring(0, kMaximumURLLengthForLogging) + "...";
 }
 
-inline HTMLTrackElement::HTMLTrackElement(Document& document)
+HTMLTrackElement::HTMLTrackElement(Document& document)
     : HTMLElement(kTrackTag, document),
       load_timer_(document.GetTaskRunner(TaskType::kNetworking),
                   this,