Commit 1cb215be authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Disable SigninInteractionControllerTestCase EG tests.

Those tests are consistently timing out on iPad, disabling them
on iPad until the root cause is fixed to turn the bots green.

Bug: 745798
Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12
Reviewed-on: https://chromium-review.googlesource.com/576171Reviewed-by: default avatarJérôme Lebel <jlebel@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487506}
parent 5696a13d
...@@ -24,6 +24,7 @@ ...@@ -24,6 +24,7 @@
#import "ios/chrome/test/earl_grey/chrome_test_case.h" #import "ios/chrome/test/earl_grey/chrome_test_case.h"
#import "ios/public/provider/chrome/browser/signin/fake_chrome_identity.h" #import "ios/public/provider/chrome/browser/signin/fake_chrome_identity.h"
#import "ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h" #import "ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h"
#import "ios/testing/earl_grey/disabled_test_macros.h"
#import "ios/testing/wait_util.h" #import "ios/testing/wait_util.h"
#if !defined(__has_feature) || !__has_feature(objc_arc) #if !defined(__has_feature) || !__has_feature(objc_arc)
...@@ -130,6 +131,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -130,6 +131,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests that opening the sign-in screen from the Settings and signing in works // Tests that opening the sign-in screen from the Settings and signing in works
// correctly when there is already an identity on the device. // correctly when there is already an identity on the device.
- (void)testSignInOneUser { - (void)testSignInOneUser {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
// Set up a fake identity. // Set up a fake identity.
ChromeIdentity* identity = GetFakeIdentity1(); ChromeIdentity* identity = GetFakeIdentity1();
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity( ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
...@@ -155,6 +161,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -155,6 +161,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests signing in with one account, switching sync account to a second and // Tests signing in with one account, switching sync account to a second and
// choosing to keep the browsing data separate during the switch. // choosing to keep the browsing data separate during the switch.
- (void)testSignInSwitchAccountsAndKeepDataSeparate { - (void)testSignInSwitchAccountsAndKeepDataSeparate {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
// Set up the fake identities. // Set up the fake identities.
ios::FakeChromeIdentityService* identity_service = ios::FakeChromeIdentityService* identity_service =
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider(); ios::FakeChromeIdentityService::GetInstanceFromChromeProvider();
...@@ -194,6 +205,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -194,6 +205,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests signing in with one account, switching sync account to a second and // Tests signing in with one account, switching sync account to a second and
// choosing to import the browsing data during the switch. // choosing to import the browsing data during the switch.
- (void)testSignInSwitchAccountsAndImportData { - (void)testSignInSwitchAccountsAndImportData {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
// Set up the fake identities. // Set up the fake identities.
ios::FakeChromeIdentityService* identity_service = ios::FakeChromeIdentityService* identity_service =
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider(); ios::FakeChromeIdentityService::GetInstanceFromChromeProvider();
...@@ -233,6 +249,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -233,6 +249,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests that switching from a managed account to a non-managed account works // Tests that switching from a managed account to a non-managed account works
// correctly and displays the expected warnings. // correctly and displays the expected warnings.
- (void)testSignInSwitchManagedAccount { - (void)testSignInSwitchManagedAccount {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
if (!experimental_flags::IsMDMIntegrationEnabled()) { if (!experimental_flags::IsMDMIntegrationEnabled()) {
EARL_GREY_TEST_SKIPPED(@"Only enabled with MDM integration."); EARL_GREY_TEST_SKIPPED(@"Only enabled with MDM integration.");
} }
...@@ -282,6 +303,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -282,6 +303,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests that signing out from the Settings works correctly. // Tests that signing out from the Settings works correctly.
- (void)testSignInDisconnectFromChrome { - (void)testSignInDisconnectFromChrome {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
ChromeIdentity* identity = GetFakeIdentity1(); ChromeIdentity* identity = GetFakeIdentity1();
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity( ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
identity); identity);
...@@ -317,6 +343,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -317,6 +343,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// Tests that signing out of a managed account from the Settings works // Tests that signing out of a managed account from the Settings works
// correctly. // correctly.
- (void)testSignInDisconnectFromChromeManaged { - (void)testSignInDisconnectFromChromeManaged {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
if (!experimental_flags::IsMDMIntegrationEnabled()) { if (!experimental_flags::IsMDMIntegrationEnabled()) {
EARL_GREY_TEST_SKIPPED(@"Only enabled with MDM integration."); EARL_GREY_TEST_SKIPPED(@"Only enabled with MDM integration.");
} }
...@@ -363,6 +394,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -363,6 +394,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// and closing the Settings correctly leaves the user signed in without any // and closing the Settings correctly leaves the user signed in without any
// Settings shown. // Settings shown.
- (void)testSignInOpenSettings { - (void)testSignInOpenSettings {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
ChromeIdentity* identity = GetFakeIdentity1(); ChromeIdentity* identity = GetFakeIdentity1();
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity( ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
identity); identity);
...@@ -467,6 +503,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) { ...@@ -467,6 +503,11 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
// that the authentication flow is correctly canceled and dismissed. // that the authentication flow is correctly canceled and dismissed.
// crbug.com/462202 // crbug.com/462202
- (void)testSignInCancelAuthenticationFlow { - (void)testSignInCancelAuthenticationFlow {
// TODO(crbug.com/745798): this test fails consistently on iPad, disabled.
if (IsIPadIdiom()) {
EARL_GREY_TEST_DISABLED(@"Disabled on iPad due to crbug.com/745798");
}
// Set up the fake identities. // Set up the fake identities.
ios::FakeChromeIdentityService* identity_service = ios::FakeChromeIdentityService* identity_service =
ios::FakeChromeIdentityService::GetInstanceFromChromeProvider(); ios::FakeChromeIdentityService::GetInstanceFromChromeProvider();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment