Commit 1cbf65b1 authored by Clark DuVall's avatar Clark DuVall Committed by Commit Bot

[Code Health] Enable gn check for //chrome/services/media_gallery_util

Bug: 949535
Change-Id: I8f958933aec6b35f61a176c2e91513e7ce2c460d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530090Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarErik Staab <estaab@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826026}
parent b4a62918
...@@ -77,8 +77,6 @@ no_check_targets = [ ...@@ -77,8 +77,6 @@ no_check_targets = [
"//chrome/services/cups_proxy/public/cpp:*", # 2 errors "//chrome/services/cups_proxy/public/cpp:*", # 2 errors
"//chrome/services/cups_proxy:*", # 6 errors "//chrome/services/cups_proxy:*", # 6 errors
"//chrome/services/ipp_parser:*", # 1 error "//chrome/services/ipp_parser:*", # 1 error
"//chrome/services/media_gallery_util/public/cpp:*", # 6 errors
"//chrome/services/media_gallery_util:*", # 3 errors
"//chrome/services/removable_storage_writer:*", # 1 error "//chrome/services/removable_storage_writer:*", # 1 error
"//chrome/services/speech:*", # 5 errors "//chrome/services/speech:*", # 5 errors
"//chrome/services/util_win:*", # 1 error "//chrome/services/util_win:*", # 1 error
......
...@@ -18,8 +18,10 @@ source_set("lib") { ...@@ -18,8 +18,10 @@ source_set("lib") {
deps = [ deps = [
"//base", "//base",
"//chrome/common",
"//media", "//media",
"//mojo/public/cpp/bindings", "//mojo/public/cpp/bindings",
"//third_party/libyuv",
] ]
if (is_android) { if (is_android) {
...@@ -55,6 +57,8 @@ if (is_android) { ...@@ -55,6 +57,8 @@ if (is_android) {
deps = [ deps = [
":lib", ":lib",
"//base/test:test_support",
"//media:test_support",
"//testing/gtest", "//testing/gtest",
] ]
} }
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "chrome/services/media_gallery_util/media_parser_factory.h" #include "chrome/services/media_gallery_util/media_parser_factory.h"
#include "base/allocator/buildflags.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chrome/services/media_gallery_util/media_parser.h" #include "chrome/services/media_gallery_util/media_parser.h"
#include "media/base/media.h" #include "media/base/media.h"
......
...@@ -16,6 +16,7 @@ source_set("cpp") { ...@@ -16,6 +16,7 @@ source_set("cpp") {
deps = [ deps = [
"//chrome/app:generated_resources", "//chrome/app:generated_resources",
"//chrome/common",
"//content/public/browser", "//content/public/browser",
"//media:media_buildflags", "//media:media_buildflags",
"//net:buildflags", "//net:buildflags",
...@@ -33,22 +34,28 @@ source_set("cpp") { ...@@ -33,22 +34,28 @@ source_set("cpp") {
} }
} }
source_set("browser_tests") { if (!is_android) {
testonly = true source_set("browser_tests") {
testonly = true
sources = [ "media_gallery_util_browsertest.cc" ]
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] sources = [ "media_gallery_util_browsertest.cc" ]
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
deps = [
"//base", deps = [
"//chrome/test:test_support", ":cpp",
"//testing/gtest", "//base",
] "//chrome/services/media_gallery_util/public/mojom",
"//chrome/test:test_support",
if (media_use_ffmpeg) { "//chrome/test:test_support_ui",
deps += [ "//testing/gtest",
"//third_party/ffmpeg", "//third_party/libyuv",
"//third_party/ffmpeg:ffmpeg_features",
] ]
if (media_use_ffmpeg) {
deps += [
"//third_party/ffmpeg",
"//third_party/ffmpeg:ffmpeg_features",
]
}
} }
} }
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "chrome/services/media_gallery_util/public/cpp/media_parser_provider.h" #include "chrome/services/media_gallery_util/public/cpp/media_parser_provider.h"
#include "base/allocator/buildflags.h"
#include "base/bind.h" #include "base/bind.h"
#include "chrome/grit/generated_resources.h" #include "chrome/grit/generated_resources.h"
#include "content/public/browser/service_process_host.h" #include "content/public/browser/service_process_host.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment