Commit 1cbfe1cc authored by David Tseng's avatar David Tseng Committed by Chromium LUCI CQ

Speculatively re-enabled some Select to Speak tests

One test was disabled prior to the migration to changes in
SpeechMonitor. Both tests pass locally under heavy load. Let's see if
they still flake.

R=akihiroota@chromium.org

Bug: 1114854, 950049
Change-Id: I6ab79c828e0bcdf3c6e3ae5034b2c3db54d4d68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584684
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: default avatarAkihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835778}
parent f924aa49
...@@ -326,8 +326,7 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, DoesNotCrashWithMousewheelEvent) { ...@@ -326,8 +326,7 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, DoesNotCrashWithMousewheelEvent) {
sm_.Replay(); sm_.Replay();
} }
// Flaky test: crbug.com/950049. IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, FocusRingMovesWithMouse) {
IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, DISABLED_FocusRingMovesWithMouse) {
// Create a callback for the focus ring observer. // Create a callback for the focus ring observer.
base::RepeatingCallback<void()> callback = base::RepeatingCallback<void()> callback =
base::BindRepeating(&SelectToSpeakTest::OnFocusRingChanged, GetWeakPtr()); base::BindRepeating(&SelectToSpeakTest::OnFocusRingChanged, GetWeakPtr());
...@@ -402,9 +401,7 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, DISABLED_FocusRingMovesWithMouse) { ...@@ -402,9 +401,7 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, DISABLED_FocusRingMovesWithMouse) {
EXPECT_EQ(focus_rings.size(), 0u); EXPECT_EQ(focus_rings.size(), 0u);
} }
// TODO(https://crbug.com/1114854): test is flaky. IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, ContinuesReadingDuringResize) {
IN_PROC_BROWSER_TEST_F(SelectToSpeakTest,
DISABLED_ContinuesReadingDuringResize) {
ActivateSelectToSpeakInWindowBounds( ActivateSelectToSpeakInWindowBounds(
"data:text/html;charset=utf-8,<p>First paragraph</p>" "data:text/html;charset=utf-8,<p>First paragraph</p>"
"<div id='resize' style='width:300px; font-size: 1em'>" "<div id='resize' style='width:300px; font-size: 1em'>"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment