Commit 1cdd1097 authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot

Remove instrumentation for bug 880741

Bug https://crbug.com/880741 is fixed. This removes the
instrumentation previously added.

Bug: 880741
Change-Id: I86ad66aa02dc470b7bcf26c697196d7eda369e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528186
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641700}
parent 5e4ec248
......@@ -5,7 +5,6 @@
#include "content/browser/frame_host/navigation_handle_impl.h"
#include "base/bind.h"
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "content/browser/appcache/appcache_navigation_handle.h"
......@@ -876,15 +875,8 @@ void NavigationHandleImpl::OnWillProcessResponseProcessed(
// If the navigation is done processing the response, then it's ready to
// commit. Inform observers that the navigation is now ready to commit,
// unless it is not set to commit (204/205s/downloads).
if (GetRenderFrameHost()) {
base::WeakPtr<NavigationHandleImpl> weak_ptr = weak_factory_.GetWeakPtr();
if (GetRenderFrameHost())
ReadyToCommitNavigation(false);
// TODO(https://crbug.com/880741): Remove this once the bug is fixed.
if (!weak_ptr) {
base::debug::DumpWithoutCrashing();
return;
}
}
} else {
state_ = CANCELING;
}
......
......@@ -1087,11 +1087,6 @@ void NavigationRequest::OnResponseStarted(
rfh, blink::mojom::WebFeature::kOpenerNavigationDownloadCrossOrigin);
}
// TODO(https://crbug.com/880741): Remove this once the bug is fixed.
if (state_ != STARTED) {
DEBUG_ALIAS_FOR_GURL(url, navigation_handle_->GetURL());
base::debug::DumpWithoutCrashing();
}
DCHECK_EQ(state_, STARTED);
DCHECK(response);
TRACE_EVENT_ASYNC_STEP_INTO0("navigation", "NavigationRequest", this,
......@@ -1852,11 +1847,6 @@ void NavigationRequest::CommitNavigation() {
render_frame_host_ ==
frame_tree_node_->render_manager()->speculative_frame_host());
// TODO(https://crbug.com/880741): Remove this once the bug is fixed.
if (!frame_tree_node_->navigation_request()) {
DEBUG_ALIAS_FOR_GURL(url, navigation_handle_->GetURL());
base::debug::DumpWithoutCrashing();
}
frame_tree_node_->TransferNavigationRequestOwnership(render_frame_host_);
if (IsPerNavigationMojoInterfaceEnabled() && request_navigation_client_ &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment