Commit 1d03a262 authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot

[LayoutNG] Write back spanner offset to the legacy object.

It may be the wrong year to do this, but fixing 22 tests with such a
tiny effort still seems worth it. :)

Bug: 829028
Change-Id: I5e34fc18edcb063d125933aac9174ff08a5acc40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860421
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706125}
parent d034974e
...@@ -920,8 +920,7 @@ void NGBlockNode::PlaceChildrenInFlowThread( ...@@ -920,8 +920,7 @@ void NGBlockNode::PlaceChildrenInFlowThread(
for (const auto& child : physical_fragment.Children()) { for (const auto& child : physical_fragment.Children()) {
if (child->GetLayoutObject() != box_) { if (child->GetLayoutObject() != box_) {
DCHECK(child->GetLayoutObject()->IsColumnSpanAll()); DCHECK(child->GetLayoutObject()->IsColumnSpanAll());
// TODO(mstensho): Write back the spanner offset to the associated CopyChildFragmentPosition(*child, child.offset);
// LayoutMultiColumnSpannerPlaceholder (if we bother)
continue; continue;
} }
// Each anonymous child of a multicol container constitutes one column. // Each anonymous child of a multicol container constitutes one column.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment