Add tests for navigation type classifications.

BUG=369661 TEST=no code changes; this adds new tests Review URL: https://codereview.chromium.org/987923002 Cr-Commit-Position: refs/heads/master@{#319894}

Add tests for navigation type classifications.
BUG=369661 TEST=no code changes; this adds new tests Review URL: https://codereview.chromium.org/987923002 Cr-Commit-Position: refs/heads/master@{#319894}
1d075900 · avi · Commit bot · 588c2d98 · 1d075900 · 1d075900
Commit 1d075900 authored Mar 10, 2015 by avi Committed by Commit bot Mar 10, 2015
3 changed files
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
--- a/content/public/browser/navigation_type.h
+++ b/content/public/browser/navigation_type.h
@@ -13,11 +13,15 @@ enum NavigationType {
  // Unknown type.
  NAVIGATION_TYPE_UNKNOWN,
-  // A new page was navigated in the main frame.
+  // A new page was navigated to in the main frame. This covers all cases where
+  // the main frame navigated and a new navigation entry was created. This means
+  // cases like navigations to a hash on the same page are NEW_PAGE, not
+  // IN_PAGE. (Navigation entries created by subframe navigations are
+  // NEW_SUBFRAME.)
  NAVIGATION_TYPE_NEW_PAGE,
-  // Renavigating to an existing navigation entry. The entry is guaranteed to
+  // Renavigating to an existing navigation entry. This is the case for history
-  // exist in the list, or else it would be a new page or IGNORE navigation.
+  // navigation, reloads, and location.replace().
  NAVIGATION_TYPE_EXISTING_PAGE,
  // The same page has been reloaded as a result of the user requesting
@@ -26,10 +30,10 @@ enum NavigationType {
  // pending entry for the load, which is then meaningless.
  NAVIGATION_TYPE_SAME_PAGE,
-  // In page navigations are when the reference fragment changes. This will
+  // The navigation was in the main frame, to a different navigation entry, but
-  // be in the main frame only (we won't even get notified of in-page
+  // appearing to the user to be a navigation within the same page. This is the
-  // subframe navigations). It may be for any page, not necessarily the last
+  // case for history.replaceState(), as well as back and forward across
-  // committed one (for example, whey going back to a page with a ref).
+  // fragment entries and history.pushState() entries.
  NAVIGATION_TYPE_IN_PAGE,
  // A new subframe was manually navigated by the user. We will create a new

--- a/content/test/data/navigation_controller/page_with_links.html
+++ b/content/test/data/navigation_controller/page_with_links.html
+<html>
+<head>
+</head>
+<body>
+<p>A page with a <a id="thelink" href="simple_page_1.html">link</a> to another page.
+<p id="frag">And a <a id="fraglink" href="#frag">fragment link</a>.
+</body>
+</html>