Commit 1d4a17ad authored by Megan Jablonski's avatar Megan Jablonski Committed by Chromium LUCI CQ

Add launched Translate languages to kDefaultSupportedLanguages

"rw", "or", "tt", "tk", and "ug" were launched by the Translate service
in March. Add those that are supported by l10n to the default Translate
supported languages list. Also update translate and l10n comment names
to match those in the Translate service.

Bug: 1150514
Change-Id: Ifd69d003c1f2b917af3ac57b2631a566c33f3853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561268Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834508}
parent bc24c252
......@@ -36,9 +36,9 @@ namespace {
// The default list of languages the Google translation server supports.
// We use this list until we receive the list that the server exposes.
// Server also supports "hmm" (Hmong) and "jw" (Javanese), but these are
// excluded because Chrome l10n library does not support it. This list must be
// sorted in alphabetical order and contain no duplicates.
// Server also supports "hmm" (Hmong), "jw" (Javanese) and "rw" (Kinyarwanda),
// but these are excluded because Chrome l10n library does not support it. This
// list must be sorted in alphabetical order and contain no duplicates.
const char* const kDefaultSupportedLanguages[] = {
"af", // Afrikaans
"am", // Amharic
......@@ -107,6 +107,7 @@ const char* const kDefaultSupportedLanguages[] = {
"nl", // Dutch
"no", // Norwegian
"ny", // Nyanja
"or", // Odia (Oriya)
"pa", // Punjabi
"pl", // Polish
"ps", // Pashto
......@@ -130,8 +131,11 @@ const char* const kDefaultSupportedLanguages[] = {
"te", // Telugu
"tg", // Tajik
"th", // Thai
"tk", // Turkmen
"tl", // Tagalog
"tr", // Turkish
"tt", // Tatar
"ug", // Uyghur
"uk", // Ukrainian
"ur", // Urdu
"uz", // Uzbek
......@@ -209,8 +213,8 @@ bool TranslateLanguageList::IsSupportedLanguage(base::StringPiece language) {
// static
GURL TranslateLanguageList::TranslateLanguageUrl() {
std::string url = translate::GetTranslateSecurityOrigin().spec() +
kLanguageListFetchPath;
std::string url =
translate::GetTranslateSecurityOrigin().spec() + kLanguageListFetchPath;
return GURL(url);
}
......
......@@ -207,7 +207,7 @@ TEST_F(LanguageSettingsMediatorTest, TestSupportedLanguagesItems) {
TEST_F(LanguageSettingsMediatorTest, TestAcceptLanguagesItems) {
translate_prefs()->AddToLanguageList("fa", /*force_blocked=*/false);
translate_prefs()->AddToLanguageList("en-US", /*force_blocked=*/false);
translate_prefs()->AddToLanguageList("ug", /*force_blocked=*/false);
translate_prefs()->AddToLanguageList("to", /*force_blocked=*/false);
translate_prefs()->SetRecentTargetLanguage("fa");
translate_prefs()->UnblockLanguage("en-US");
......@@ -225,7 +225,7 @@ TEST_F(LanguageSettingsMediatorTest, TestAcceptLanguagesItems) {
EXPECT_FALSE(acceptLanguagesItems[1].targetLanguage);
EXPECT_FALSE(acceptLanguagesItems[1].blocked);
EXPECT_EQ("ug", acceptLanguagesItems[2].languageCode);
EXPECT_EQ("to", acceptLanguagesItems[2].languageCode);
EXPECT_FALSE(acceptLanguagesItems[2].supportsTranslate);
EXPECT_FALSE(acceptLanguagesItems[2].targetLanguage);
EXPECT_TRUE(acceptLanguagesItems[2].blocked);
......
......@@ -168,7 +168,7 @@ static const char* const kAcceptLanguageList[] = {
"ny", // Nyanja
"oc", // Occitan
"om", // Oromo
"or", // Oriya
"or", // Odia (Oriya)
"pa", // Punjabi
"pl", // Polish
"ps", // Pashto
......@@ -203,7 +203,7 @@ static const char* const kAcceptLanguageList[] = {
"tr", // Turkish
"tt", // Tatar
"tw", // Twi
"ug", // Uighur
"ug", // Uyghur
"uk", // Ukrainian
"ur", // Urdu
"uz", // Uzbek
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment