Disable focus highlight overlay for non-touch mode on ContentView.

On O+, Android draws a translucent grey overlay over focused views when
the device is not in touch mode (as in, the user is using keyboard to
navigate rather than touch/mouse). Drawing this overlay over the entire
ContentView doesn't make sense, so we should just disable it.
We also have to disable it for the CompositorViewHolder, or when we
go between NativePages (like NTP) and WebContents, we animate into and
out of the grey overlay, because the CompositorViewHolder briefly
gains focus.

Bug: 912724, 908917
Change-Id: I97b7f688f06581e872898028a48e6e7b4546d710
Reviewed-on: https://chromium-review.googlesource.com/c/1367926Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614783}

base/android/java/src/org/chromium/base/compat/ApiHelperForO.java

@@ -9,6 +9,7 @@ import android.content.pm.PackageManager;
 import android.content.res.Configuration;
 import android.os.Build;
 import android.view.Display;
+import android.view.View;
 
 import org.chromium.base.annotations.DoNotInline;
 
@@ -36,4 +37,9 @@ public final class ApiHelperForO {
     public static boolean isInstantApp(PackageManager packageManager) {
         return packageManager.isInstantApp();
     }
+
+    /** See {@link View#setDefaultFocusHighlightEnabled(boolean) }. */
+    public static void setDefaultFocusHighlightEnabled(View view, boolean enabled) {
+        view.setDefaultFocusHighlightEnabled(enabled);
+    }
 }

chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

@@ -32,6 +32,7 @@ import android.widget.FrameLayout;
 
 import org.chromium.base.SysUtils;
 import org.chromium.base.TraceEvent;
+import org.chromium.base.compat.ApiHelperForO;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.InsetObserverView;
 import org.chromium.chrome.browser.autofill.keyboard_accessory.KeyboardExtensionSizeManager;
@@ -269,6 +270,10 @@ public class CompositorViewHolder extends FrameLayout
             }
         });
         handleSystemUiVisibilityChange();
+
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+            ApiHelperForO.setDefaultFocusHighlightEnabled(this, false);
+        }
     }
 
     private Point getViewportSize() {

components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java

@@ -21,6 +21,7 @@ import android.view.inputmethod.InputConnection;
 import android.widget.FrameLayout;
 
 import org.chromium.base.TraceEvent;
+import org.chromium.base.compat.ApiHelperForO;
 import org.chromium.content_public.browser.ImeAdapter;
 import org.chromium.content_public.browser.RenderCoordinates;
 import org.chromium.content_public.browser.SmartClipProvider;
@@ -84,6 +85,10 @@ public class ContentView
 
         setFocusable(true);
         setFocusableInTouchMode(true);
+
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+            ApiHelperForO.setDefaultFocusHighlightEnabled(this, false);
+        }
     }
 
     protected WebContentsAccessibility getWebContentsAccessibility() {