[Subresource Filter] Componentize TestRulesetPublisher
This class will be reused in //weblayer browsertests. The componentization requires passing in the RulesetService rather than obtaining it internally from the //chrome-level BrowserProcess global. This in turn causes a slight hiccup in //chrome's subresource filter browsertest harness: the browser process global is not available until SubresourceFilterBrowserTest::SetUpInMainThread(), but many subclasses of SubresourceFilterBrowserTest don't invoke SubresourceFilterBrowserTest::SetUpInMainThread() from their own SetUpInMainThread() methods, and can't be made to in a straightforward way due to dependency issues (some of the code in the subclass' SetUpInMainThread would need to run before SubresourceFilterBrowserTest' and some after). I left that yak to shave for another day and turned TestRulesetPublisher into a local variable in the two SubresourceFilterBrowserTest methods that need it. Bug: 1116095 Change-Id: I453b277e1c3290b169170383aa6531d34db32cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527054Reviewed-by:Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#826819}
Showing
Please register or sign in to comment