Commit 1d98a82e authored by Patrick Brosset's avatar Patrick Brosset Committed by Chromium LUCI CQ

DevTools: Re-enable a couple of grid-related web tests

We are removing the cssGridFeatures experiment in DevTools (the feature
still exists, it is no longer an experiment).
2 web tests need to be modified to ensure relevant grid-related cases
are taken into account.

These cases were previously removed in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2418315

Bug: 1162894
Change-Id: Ic0cfad3581590326feccd58d54e3d74eeea0dcd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608663Reviewed-by: default avatarBrandon Goddard <brgoddar@microsoft.com>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#840580}
parent edef3b1e
......@@ -6,6 +6,7 @@ frontend: {"id":<number>,"method":"CSS.disable","params":{}}
frontend: {"id":<number>,"method":"Debugger.setAsyncCallStackDepth","params":{"maxDepth":0}}
frontend: {"id":<number>,"method":"Overlay.disable","params":{}}
frontend: {"id":<number>,"method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":false,"flatten":true}}
frontend: {"id":<number>,"method":"Overlay.setShowGridOverlays","params":{"gridNodeHighlightConfigs":[]}}
frontend: {"id":<number>,"method":"Debugger.disable","params":{}}
--> SDK.targetManager.resumeAllTargets();
......
......@@ -20,12 +20,7 @@
ProtocolClient.test.dumpProtocol = null;
for (var i = 0; i < messages.length; ++i) {
var message = messages[i];
if (message.startsWith('backend'))
continue;
// Manually remove "Grid" because CSS Grid is still experimental but enabled by default
// see: https://crrev.com/c/2416525
// TODO: remove this and update test expectations once CSS Grid is non-experimental
if (message.includes('setShowGridOverlays')) {
if (message.startsWith('backend')) {
continue;
}
message = message.replace(/"id":\d+,/, '"id":<number>,');
......
......@@ -7,6 +7,7 @@ Has category: Debugger
Has category: Drawer
Has category: Elements
Has category: Global
Has category: Grid
Has category: Mobile
Has category: Network
Has category: Panel
......
......@@ -13,11 +13,6 @@
commands.set(command.category() + ': ' + command.title(), command);
});
// Manually remove "Grid" because CSS Grid is still experimental but enabled by default
// see: https://crrev.com/c/2416525
// TODO: remove this and update test expectations once CSS Grid is non-experimental
categories.delete('Grid');
TestRunner.addResult('Categories active:');
Array.from(categories).sort().forEach(category => TestRunner.addResult('Has category: ' + category));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment