Commit 1db22fc2 authored by Samuel Huang's avatar Samuel Huang Committed by Commit Bot

[SuperSize] Disable archiving native code for Tricrome Chrome.

Running SuperSize-archive on TrichromeGoogle.ssargs fails because the
largest .so file cames from Google3, but its data (.map and unstripped
.so file) are unavailable.

This CL implements a workaround: Change Trichrome's generated .ssargs
files to specify --no-native for Trichrome Chrome to disable native
code processing.

Bug: 1103271, 1040645
Change-Id: I1af591738ef6b1e8375c21b3272017a5da1fd6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293167Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787796}
parent 753fc204
...@@ -216,7 +216,8 @@ template("write_ssargs_trichrome") { ...@@ -216,7 +216,8 @@ template("write_ssargs_trichrome") {
ssargs_lines = [ ssargs_lines = [
"# Written by build target \"${target_name}.\"", "# Written by build target \"${target_name}.\"",
"Library -f ${invoker.trichrome_library_basename}", "Library -f ${invoker.trichrome_library_basename}",
"Chrome -f ${invoker.trichrome_chrome_basename}", "# Add --no-native to Chrome as workaround for crbug.com/1103271.",
"Chrome -f ${invoker.trichrome_chrome_basename} --no-native",
"WebView -f ${invoker.trichrome_webview_basename}", "WebView -f ${invoker.trichrome_webview_basename}",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment