Remove the Expected Failures tab

Adam says this is no longer used.

BUG=389681
R=abarth@chromium.org, abarth, dpranke

Review URL: https://codereview.chromium.org/360553005

git-svn-id: svn://svn.chromium.org/blink/trunk@177146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Tools/GardeningServer/scripts/controllers.js

@@ -82,42 +82,6 @@ controllers.ResultsDetails = base.extends(Object, {
     }
 });
 
-controllers.ExpectedFailures = base.extends(Object, {
-    init: function(model, view, delegate)
-    {
-        this._model = model;
-        this._view = view;
-        this._delegate = delegate;
-    },
-    update: function()
-    {
-        var expectedFailures = results.expectedFailuresByTest(this._model.resultsByBuilder);
-        var failingTestsList = Object.keys(expectedFailures);
-
-        $(this._view).empty();
-        base.forEachDirectory(failingTestsList, function(label, testsFailingInDirectory) {
-            var listItem = new ui.failures.ListItem(label, testsFailingInDirectory);
-            this._view.appendChild(listItem);
-            $(listItem).bind('examine', function() {
-                this.onExamine(testsFailingInDirectory);
-            }.bind(this));
-        }.bind(this));
-    },
-    onExamine: function(failingTestsList)
-    {
-        var resultsView = new ui.results.View({
-            fetchResultsURLs: results.fetchResultsURLs
-        });
-        var failuresByTest = base.filterDictionary(
-            results.expectedFailuresByTest(this._model.resultsByBuilder),
-            function(key) {
-                return failingTestsList.indexOf(key) != -1;
-            });
-        var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
-        this._delegate.showResults(resultsView);
-    }
-});
-
 var FailureStreamController = base.extends(Object, {
     _resultsFilter: null,
     _keyFor: function(failureAnalysis) { throw "Not implemented!"; },

third_party/WebKit/Tools/GardeningServer/scripts/garden-o-matic.js

@@ -32,7 +32,6 @@ var g_updateTimerId = 0;
 var g_buildersFailing = null;
 
 var g_unexpectedFailuresController = null;
-var g_failuresController = null;
 
 var g_nonLayoutTestFailureBuilders = null;
 
@@ -80,9 +79,6 @@ function update()
     });
 
     Promise.all([model.updateRecentCommits(), model.updateResultsByBuilder()]).then(function() {
-        if (g_failuresController)
-            g_failuresController.update();
-
         updating.update('Analyzing test failures ...');
 
         model.analyzeUnexpectedFailures(function(failureAnalysis, total) {
@@ -154,13 +150,6 @@ $(document).ready(function() {
     unexpected.appendChild(g_info);
     unexpected.appendChild(unexpectedFailuresView);
 
-    var expected = onebar.expected();
-    if (expected) {
-        var failuresView = new ui.failures.List();
-        g_failuresController = new controllers.ExpectedFailures(model.state, failuresView, onebarController);
-        expected.appendChild(failuresView);
-    }
-
     update();
 });
 

third_party/WebKit/Tools/GardeningServer/scripts/model.js

@@ -195,21 +195,4 @@ model.unexpectedFailureInfoForTestName = function(testName)
     });
 };
 
-// failureCallback is called multiple times: once for each failure
-model.analyzeexpectedFailures = function(failureCallback)
-{
-    var expectedFailures = results.expectedFailuresByTest(model.state.resultsByBuilder);
-    $.each(expectedFailures, function(testName, resultNodesByBuilder) {
-        var failureAnalysis = {
-            'testName': testName,
-            'resultNodesByBuilder': resultNodesByBuilder,
-        };
-
-        // FIXME: Consider looking at the history to see how long this test
-        // has been failing.
-
-        failureCallback(failureAnalysis);
-    });
-};
-
 })();

third_party/WebKit/Tools/GardeningServer/scripts/ui.js

@@ -109,22 +109,19 @@ ui.onebar = base.extends('div', {
         this.innerHTML =
             '<ul>' +
                 '<li><a href="#unexpected">Unexpected Failures</a></li>' +
-                '<li><a href="#expected">Expected Failures</a></li>' +
                 '<li><a href="#results">Results</a></li>' +
             '</ul>' +
             '<div id="link-handling"><input type="checkbox" id="new-window-for-links"><label for="new-window-for-links">Open links in new window</label></div>' +
             '<div id="unexpected"></div>' +
-            '<div id="expected"></div>' +
             '<div id="results"></div>';
         this._tabNames = [
             'unexpected',
-            'expected',
             'results',
         ]
 
         this._tabIndexToSavedScrollOffset = {};
         this._tabs = $(this).tabs({
-            disabled: [2],
+            disabled: [this._tabNames.indexOf('results')],
             show: function(event, ui) { this._restoreScrollOffset(ui.index); },
             select: function(event, ui) {
                 this._saveScrollOffset();
@@ -190,10 +187,6 @@ ui.onebar = base.extends('div', {
     {
         return this.tabNamed('unexpected');
     },
-    expected: function()
-    {
-        return this.tabNamed('expected');
-    },
     results: function()
     {
         return this.tabNamed('results');

third_party/WebKit/Tools/GardeningServer/scripts/ui/failures.js

@@ -133,24 +133,4 @@ ui.failures.FailureGrid = base.extends('table', {
     }
 });
 
-ui.failures.ListItem = base.extends('li', {
-    init: function(groupName, failingTestsList)
-    {
-        this._failingTestsList = failingTestsList;
-        this.appendChild(new ui.actions.List([
-            new ui.actions.Examine().makeDefault(),
-        ]));
-        var label = this.appendChild(document.createElement('label'))
-        label.textContent = failingTestsList.length == 1 ? failingTestsList[0] : groupName;
-    },
-});
-
-ui.failures.List = base.extends('ul', {
-    init: function()
-    {
-        this.className = 'failures';
-        this.textContent = 'Loading...';
-    }
-});
-
 })();

third_party/WebKit/Tools/GardeningServer/scripts/ui_unittests.js

@@ -46,7 +46,7 @@ var kExampleResultsByTest = {
     }
 }
 
-test("ui.onebar", 3, function() {
+test("ui.onebar", 2, function() {
     if (window.location.hash) {
         window.location.hash = '';
     }
@@ -56,16 +56,12 @@ test("ui.onebar", 3, function() {
     equal(onebar.innerHTML,
         '<ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all">' +
             '<li class="ui-state-default ui-corner-top ui-tabs-selected ui-state-active"><a href="#unexpected">Unexpected Failures</a></li>' +
-            '<li class="ui-state-default ui-corner-top"><a href="#expected">Expected Failures</a></li>' +
             '<li class="ui-state-default ui-corner-top ui-state-disabled"><a href="#results">Results</a></li>' +
         '</ul>' +
         '<div id="link-handling"><input type="checkbox" id="new-window-for-links"><label for="new-window-for-links">Open links in new window</label></div>' +
         '<div id="unexpected" class="ui-tabs-panel ui-widget-content ui-corner-bottom"></div>' +
-        '<div id="expected" class="ui-tabs-panel ui-widget-content ui-corner-bottom ui-tabs-hide"></div>' +
         '<div id="results" class="ui-tabs-panel ui-widget-content ui-corner-bottom ui-tabs-hide"></div>');
 
-    onebar.select('expected');
-    equal(window.location.hash, '#expected');
     onebar.select('unexpected');
     equal(window.location.hash, '#unexpected');