Commit 1dbde9ea authored by estade's avatar estade Committed by Commit bot

Autofill - improve Macy's and Best Buy checkout by parsing input type="tel"

for CVC and PAN fields.

BUG=427103,427012

Review URL: https://codereview.chromium.org/681843002

Cr-Commit-Position: refs/heads/master@{#301508}
parent 5b68c67d
UNKNOWN_TYPE | selCreditCardType | Credit CardCard Type | | selCreditCardType_1-default
UNKNOWN_TYPE | cardNumber | Card Number | | selCreditCardType_1-default
UNKNOWN_TYPE | expirery-month | Credit CardCard Type | | selCreditCardType_1-default
UNKNOWN_TYPE | expirery-year | Credit CardCard Type | | selCreditCardType_1-default
UNKNOWN_TYPE | securityCode | Security Code | | selCreditCardType_1-default
CREDIT_CARD_TYPE | selCreditCardType | Credit CardCard Type | | selCreditCardType_1-cc
CREDIT_CARD_NUMBER | cardNumber | Card Number | | selCreditCardType_1-cc
CREDIT_CARD_EXP_MONTH | expirery-month | Credit CardCard Type | | selCreditCardType_1-cc
CREDIT_CARD_EXP_4_DIGIT_YEAR | expirery-year | Credit CardCard Type | | selCreditCardType_1-cc
CREDIT_CARD_VERIFICATION_CODE | securityCode | Security Code | | selCreditCardType_1-cc
UNKNOWN_TYPE | TxtRzMembershipId | Member IDDon't Know it? | | selCreditCardType_1-default
UNKNOWN_TYPE | /bestbuy/digiterra/commerce/order/formhandler/CheckoutPaymentFormHandler.SVCNumber | Card Number or Code | | selCreditCardType_1-default
UNKNOWN_TYPE | /bestbuy/digiterra/commerce/order/formhandler/CheckoutPaymentFormHandler.SVCCID | Security Code | | selCreditCardType_1-default
......
UNKNOWN_TYPE | creditCard.cardType.code | card type: | -1 | creditCard.cardType.code_1-default
UNKNOWN_TYPE | creditCard.cardNumber | card number: | | creditCard.cardType.code_1-default
UNKNOWN_TYPE | creditCard.expMonth | expiration: | -1 | creditCard.cardType.code_1-default
UNKNOWN_TYPE | creditCard.expYear | expiration: | -1 | creditCard.cardType.code_1-default
UNKNOWN_TYPE | creditCard.securityCode | please enter security code: | | creditCard.cardType.code_1-default
CREDIT_CARD_TYPE | creditCard.cardType.code | card type: | -1 | creditCard.cardType.code_1-cc
CREDIT_CARD_NUMBER | creditCard.cardNumber | card number: | | creditCard.cardType.code_1-cc
CREDIT_CARD_EXP_MONTH | creditCard.expMonth | expiration: | -1 | creditCard.cardType.code_1-cc
CREDIT_CARD_EXP_4_DIGIT_YEAR | creditCard.expYear | expiration: | -1 | creditCard.cardType.code_1-cc
CREDIT_CARD_VERIFICATION_CODE | creditCard.securityCode | please enter security code: | | creditCard.cardType.code_1-cc
UNKNOWN_TYPE | creditCard.billingContact.shippingAddressAsBillingAddress | Use my Shipping Address | true | creditCard.cardType.code_1-default
NAME_FIRST | creditCard.billingContact.firstName | first name: | | creditCard.cardType.code_1-default
NAME_LAST | creditCard.billingContact.lastName | last name: | | creditCard.cardType.code_1-default
......
......@@ -88,14 +88,21 @@ FormField* CreditCardField::Parse(AutofillScanner* scanner) {
// "verification number", "card identification number" and others listed
// in the |pattern| below.
base::string16 pattern = base::UTF8ToUTF16(autofill::kCardCvcRe);
// Some sites use type="tel" for numerical inputs.
if (!credit_card_field->verification_ &&
ParseField(scanner, pattern, &credit_card_field->verification_)) {
ParseFieldSpecifics(scanner,
pattern,
MATCH_DEFAULT | MATCH_TELEPHONE,
&credit_card_field->verification_)) {
continue;
}
pattern = base::UTF8ToUTF16(autofill::kCardNumberRe);
AutofillField* current_number_field;
if (ParseField(scanner, pattern, &current_number_field)) {
if (ParseFieldSpecifics(scanner,
pattern,
MATCH_DEFAULT | MATCH_TELEPHONE,
&current_number_field)) {
// Avoid autofilling any credit card number field having very low or high
// |start_index| on the HTML form.
size_t start_index = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment