Commit 1dc39c2c authored by Oriol Brufau's avatar Oriol Brufau Committed by Commit Bot

[css-logical] Replace uses of webkit-prefixed logical properties with standard...

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/common

Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /chrome/common

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: Ic8ec1308146f68a7c1bf82f850361adb3b4b63f8
Reviewed-on: https://chromium-review.googlesource.com/1150025Reviewed-by: default avatarPaul Irish <paulirish@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577905}
parent c43c331c
...@@ -74,8 +74,8 @@ html[dir='rtl'] div.weakrtl input { ...@@ -74,8 +74,8 @@ html[dir='rtl'] div.weakrtl input {
} }
html[dir='rtl'] .favicon-cell.weakrtl { html[dir='rtl'] .favicon-cell.weakrtl {
-webkit-padding-end: 22px; padding-inline-end: 22px;
-webkit-padding-start: 0; padding-inline-start: 0;
} }
/* weakrtl for selection drop downs needs to account for the fact that /* weakrtl for selection drop downs needs to account for the fact that
......
...@@ -94,7 +94,6 @@ html[dir='rtl'] .overlay .page > .close-button { ...@@ -94,7 +94,6 @@ html[dir='rtl'] .overlay .page > .close-button {
} }
.overlay .page h1 { .overlay .page h1 {
-webkit-padding-end: 24px;
-webkit-user-select: none; -webkit-user-select: none;
color: #333; color: #333;
/* 120% of the body's font-size of 84% is 16px. This will keep the relative /* 120% of the body's font-size of 84% is 16px. This will keep the relative
...@@ -138,8 +137,8 @@ html[dir='rtl'] .overlay .page .action-area { ...@@ -138,8 +137,8 @@ html[dir='rtl'] .overlay .page .action-area {
} }
.overlay .page .button-strip > button { .overlay .page .button-strip > button {
-webkit-margin-start: 10px;
display: block; display: block;
margin-inline-start: 10px;
} }
/* On OSX 10.7, hidden scrollbars may prevent the user from realizing that the /* On OSX 10.7, hidden scrollbars may prevent the user from realizing that the
......
...@@ -3,8 +3,8 @@ ...@@ -3,8 +3,8 @@
* found in the LICENSE file. */ * found in the LICENSE file. */
body.uber-frame { body.uber-frame {
-webkit-margin-start: 155px;
color: rgb(48, 57, 66); color: rgb(48, 57, 66);
margin-inline-start: 155px;
} }
html[dir='rtl'] body.uber-frame { html[dir='rtl'] body.uber-frame {
...@@ -19,7 +19,7 @@ body.uber-frame #extension-settings.page, ...@@ -19,7 +19,7 @@ body.uber-frame #extension-settings.page,
body.uber-frame #mainview-content .page, body.uber-frame #mainview-content .page,
body.uber-frame .subpage-sheet-container .page, body.uber-frame .subpage-sheet-container .page,
body.uber-frame > .page { body.uber-frame > .page {
-webkit-margin-end: 24px; margin-inline-end: 24px;
min-width: 576px; min-width: 576px;
padding-bottom: 20px; padding-bottom: 20px;
padding-top: 55px; padding-top: 55px;
...@@ -31,7 +31,7 @@ body.uber-frame header { ...@@ -31,7 +31,7 @@ body.uber-frame header {
rgba(255, 255, 255, 0.92)); rgba(255, 255, 255, 0.92));
left: 155px; left: 155px;
/* <section>s in options currently amount to 638px total, broken up into /* <section>s in options currently amount to 638px total, broken up into
* 600px max-width + 18px -webkit-padding-start + 20px -webkit-margin-end * 600px max-width + 18px padding-inline-start + 20px margin-inline-end
* so we mirror this value here so the headers match width and horizontal * so we mirror this value here so the headers match width and horizontal
* alignment when scrolling sideways. */ * alignment when scrolling sideways. */
max-width: 738px; max-width: 738px;
...@@ -78,11 +78,11 @@ body.uber-frame header > h1 { ...@@ -78,11 +78,11 @@ body.uber-frame header > h1 {
/* Create a border under the h1 (but before anything that gets appended /* Create a border under the h1 (but before anything that gets appended
* to the end of the header). */ * to the end of the header). */
body.uber-frame header > h1::after { body.uber-frame header > h1::after {
-webkit-margin-end: 20px;
background-color: #eee; background-color: #eee;
content: ' '; content: ' ';
display: block; display: block;
height: 1px; height: 1px;
margin-inline-end: 20px;
position: relative; position: relative;
top: 13px; top: 13px;
} }
...@@ -99,10 +99,10 @@ body.uber-frame footer { ...@@ -99,10 +99,10 @@ body.uber-frame footer {
/* Sections are used in options pages, help page and history page. This defines /* Sections are used in options pages, help page and history page. This defines
* the section metrics to match the header metrics above. */ * the section metrics to match the header metrics above. */
body.uber-frame section { body.uber-frame section {
-webkit-padding-start: 18px;
margin-bottom: 24px; margin-bottom: 24px;
margin-top: 8px; margin-top: 8px;
max-width: 600px; max-width: 600px;
padding-inline-start: 18px;
} }
body.uber-frame section:last-of-type { body.uber-frame section:last-of-type {
...@@ -110,7 +110,7 @@ body.uber-frame section:last-of-type { ...@@ -110,7 +110,7 @@ body.uber-frame section:last-of-type {
} }
body.uber-frame section > h3 { body.uber-frame section > h3 {
-webkit-margin-start: -18px; margin-inline-start: -18px;
} }
body.uber-frame section > div:only-of-type { body.uber-frame section > div:only-of-type {
......
...@@ -46,19 +46,19 @@ select { ...@@ -46,19 +46,19 @@ select {
:-webkit-any(button, :-webkit-any(button,
input[type='button'], input[type='button'],
input[type='submit']):not(.custom-appearance):not(.link-button) { input[type='submit']):not(.custom-appearance):not(.link-button) {
-webkit-padding-end: 10px; padding-inline-end: 10px;
-webkit-padding-start: 10px; padding-inline-start: 10px;
} }
select { select {
-webkit-appearance: none; -webkit-appearance: none;
-webkit-padding-end: 20px;
-webkit-padding-start: 6px;
/* OVERRIDE */ /* OVERRIDE */
background-image: url('../images/select.png'), background-image: url('../images/select.png'),
-webkit-linear-gradient(#ededed, #ededed 38%, #dedede); -webkit-linear-gradient(#ededed, #ededed 38%, #dedede);
background-position: right center; background-position: right center;
background-repeat: no-repeat; background-repeat: no-repeat;
padding-inline-end: 20px;
padding-inline-start: 6px;
} }
html[dir='rtl'] select { html[dir='rtl'] select {
...@@ -292,9 +292,9 @@ input:disabled:-webkit-any([type='password'], ...@@ -292,9 +292,9 @@ input:disabled:-webkit-any([type='password'],
} }
:-webkit-any(.checkbox, .radio) label input ~ span { :-webkit-any(.checkbox, .radio) label input ~ span {
-webkit-margin-start: 0.6em;
/* Make sure long spans wrap at the same horizontal position they start. */ /* Make sure long spans wrap at the same horizontal position they start. */
display: block; display: block;
margin-inline-start: 0.6em;
} }
:-webkit-any(.checkbox, .radio) label:hover { :-webkit-any(.checkbox, .radio) label:hover {
......
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
<link rel="stylesheet" href="slider.css"> <link rel="stylesheet" href="slider.css">
<style> <style>
body.uber-frame { body.uber-frame {
-webkit-margin-start: 18px; margin-inline-start: 18px;
-webkit-margin-end: 30px; margin-inline-end: 30px;
} }
body.uber-frame section { body.uber-frame section {
...@@ -29,8 +29,8 @@ body.uber-frame section:last-of-type { ...@@ -29,8 +29,8 @@ body.uber-frame section:last-of-type {
} }
body.uber-frame header { body.uber-frame header {
-webkit-padding-start: 18px;
left: 0; left: 0;
padding-inline-start: 18px;
right: 0; right: 0;
} }
...@@ -65,7 +65,7 @@ section { ...@@ -65,7 +65,7 @@ section {
} }
.font-settings-div { .font-settings-div {
-webkit-margin-end: 5px; margin-inline-end: 5px;
width: 180px; width: 180px;
} }
...@@ -128,13 +128,13 @@ select { ...@@ -128,13 +128,13 @@ select {
} }
#footer > button { #footer > button {
-webkit-padding-start: 9px; padding-inline-start: 9px;
-webkit-padding-end: 9px; padding-inline-end: 9px;
} }
#footer > #apply-settings { #footer > #apply-settings {
-webkit-padding-start: 17px; padding-inline-start: 17px;
-webkit-padding-end: 17px; padding-inline-end: 17px;
} }
#apply-settings:enabled { #apply-settings:enabled {
......
/* /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
Copyright (c) 2011 The Chromium Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be
Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. */
found in the LICENSE file.
*/
body { body {
font-family: Helvetica, sans-serif; font-family: Helvetica, sans-serif;
...@@ -38,7 +36,7 @@ body { ...@@ -38,7 +36,7 @@ body {
.plugin-description { .plugin-description {
display: inline-block; display: inline-block;
-webkit-padding-start: 7px; padding-inline-start: 7px;
width: auto; width: auto;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
...@@ -76,8 +74,8 @@ li.plugin-show-details { ...@@ -76,8 +74,8 @@ li.plugin-show-details {
} }
.column-headers { .column-headers {
-webkit-margin-start: 17px;
display: -webkit-box; display: -webkit-box;
margin-inline-start: 17px;
} }
.column-headers > div { .column-headers > div {
......
/* /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
Copyright (c) 2011 The Chromium Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be
Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. */
found in the LICENSE file.
*/
.rule-pattern { .rule-pattern {
-webkit-box-flex: 1; -webkit-box-flex: 1;
-webkit-margin-end: 10px; margin-inline-end: 10px;
-webkit-margin-start: 14px; margin-inline-start: 14px;
} }
.rule-behavior { .rule-behavior {
......
/* Copyright (c) 2011 The Chromium Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file. */
/* Styles common to WebUI pages that share the options pages style */ /* Styles common to WebUI pages that share the options pages style */
body { body {
cursor: default; cursor: default;
...@@ -13,7 +17,6 @@ a:active { ...@@ -13,7 +17,6 @@ a:active {
} }
#navbar-content-title { #navbar-content-title {
-webkit-padding-end: 24px;
-webkit-user-select: none; -webkit-user-select: none;
color: #53637d; color: #53637d;
cursor: pointer; cursor: pointer;
...@@ -21,6 +24,7 @@ a:active { ...@@ -21,6 +24,7 @@ a:active {
font-weight: normal; font-weight: normal;
margin: 0; margin: 0;
padding-bottom: 14px; padding-bottom: 14px;
padding-inline-end: 24px;
padding-top: 13px; padding-top: 13px;
text-align: end; text-align: end;
text-shadow: white 0 1px 2px; text-shadow: white 0 1px 2px;
...@@ -40,9 +44,9 @@ a:active { ...@@ -40,9 +44,9 @@ a:active {
} }
#navbar-container { #navbar-container {
-webkit-border-end: 1px solid #c6c9ce;
background: -webkit-linear-gradient(rgba(234, 238, 243, 0.2), #eaeef3), background: -webkit-linear-gradient(rgba(234, 238, 243, 0.2), #eaeef3),
-webkit-linear-gradient(left, #eaeef3, #eaeef3 97%, #d3d7db); -webkit-linear-gradient(left, #eaeef3, #eaeef3 97%, #d3d7db);
border-inline-end: 1px solid #c6c9ce;
position: fixed; position: fixed;
bottom: 0; bottom: 0;
/* We set both left and right for the sake of RTL. */ /* We set both left and right for the sake of RTL. */
...@@ -78,9 +82,9 @@ html.hide-menu #navbar-container { ...@@ -78,9 +82,9 @@ html.hide-menu #navbar-container {
font-size: 105%; font-size: 105%;
outline: none; outline: none;
padding: 7px 0; padding: 7px 0;
padding-inline-end: 24px;
text-align: end; text-align: end;
text-shadow: white 0 1px 1px; text-shadow: white 0 1px 1px;
-webkit-padding-end: 24px;
} }
.navbar-item:focus { .navbar-item:focus {
...@@ -99,10 +103,10 @@ html.hide-menu #navbar-container { ...@@ -99,10 +103,10 @@ html.hide-menu #navbar-container {
#mainview { #mainview {
-webkit-box-align: stretch; -webkit-box-align: stretch;
-webkit-padding-start: 216px;
margin: 0; margin: 0;
position: absolute; position: absolute;
left: 0; left: 0;
padding-inline-start: 216px;
right: 0; right: 0;
top: 0; top: 0;
bottom: 0; bottom: 0;
...@@ -110,7 +114,7 @@ html.hide-menu #navbar-container { ...@@ -110,7 +114,7 @@ html.hide-menu #navbar-container {
} }
html.hide-menu #mainview { html.hide-menu #mainview {
-webkit-padding-start: 0; padding-inline-start: 0;
} }
#mainview-content { #mainview-content {
...@@ -216,8 +220,8 @@ html[dir='rtl'] div.weakrtl input { ...@@ -216,8 +220,8 @@ html[dir='rtl'] div.weakrtl input {
} }
html[dir='rtl'] .favicon-cell.weakrtl { html[dir='rtl'] .favicon-cell.weakrtl {
-webkit-padding-end: 22px; padding-inline-end: 22px;
-webkit-padding-start: 0; padding-inline-start: 0;
} }
/* weakrtl for selection drop downs needs to account for the fact that /* weakrtl for selection drop downs needs to account for the fact that
...@@ -242,7 +246,6 @@ html[dir='rtl'] .weakrtl input::-webkit-input-placeholder { ...@@ -242,7 +246,6 @@ html[dir='rtl'] .weakrtl input::-webkit-input-placeholder {
} }
.page h1 { .page h1 {
-webkit-padding-end: 24px;
-webkit-user-select: none; -webkit-user-select: none;
border-bottom: 1px solid #eeeeee; border-bottom: 1px solid #eeeeee;
color: #53637d; color: #53637d;
...@@ -250,6 +253,7 @@ html[dir='rtl'] .weakrtl input::-webkit-input-placeholder { ...@@ -250,6 +253,7 @@ html[dir='rtl'] .weakrtl input::-webkit-input-placeholder {
font-weight: normal; font-weight: normal;
margin: 0; margin: 0;
padding-bottom: 4px; padding-bottom: 4px;
padding-inline-end: 24px;
padding-top: 13px; padding-top: 13px;
text-shadow: white 0 1px 2px; text-shadow: white 0 1px 2px;
} }
......
...@@ -9,8 +9,6 @@ select { ...@@ -9,8 +9,6 @@ select {
-webkit-appearance: button; -webkit-appearance: button;
-webkit-border-radius: 2px; -webkit-border-radius: 2px;
-webkit-box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1); -webkit-box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);
-webkit-padding-end: 20px;
-webkit-padding-start: 2px;
-webkit-user-select: none; -webkit-user-select: none;
background-image: url("../images/select.png"), background-image: url("../images/select.png"),
-webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5); -webkit-linear-gradient(#fafafa, #f4f4f4 40%, #e5e5e5);
...@@ -22,6 +20,8 @@ select { ...@@ -22,6 +20,8 @@ select {
margin: 0; margin: 0;
overflow: hidden; overflow: hidden;
padding-top: 2px; padding-top: 2px;
padding-inline-end: 20px;
padding-inline-start: 2px;
padding-bottom: 2px; padding-bottom: 2px;
text-overflow: ellipsis; text-overflow: ellipsis;
white-space: nowrap; white-space: nowrap;
......
...@@ -62,8 +62,8 @@ list .deletable-item { ...@@ -62,8 +62,8 @@ list .deletable-item {
list .deletable-item > :first-child { list .deletable-item > :first-child {
-webkit-box-align: center; -webkit-box-align: center;
-webkit-box-flex: 1; -webkit-box-flex: 1;
-webkit-padding-end: 5px;
display: -webkit-box; display: -webkit-box;
padding-inline-end: 5px;
} }
list .close-button { list .close-button {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment