Commit 1dc8a928 authored by bratell's avatar bratell Committed by Commit bot

Binary size tool: Don't escape text that won't be parsed.

Only text that will be sent through an HTML parser needs to be parsed.
Escaping more than that results in & and < and similar in the
output.

R=andrewhayden@chromium.org

BUG=412708

Review URL: https://codereview.chromium.org/562623002

Cr-Commit-Position: refs/heads/master@{#294176}
parent 8c2d2787
...@@ -133,19 +133,19 @@ function bigSymbolsReport() { ...@@ -133,19 +133,19 @@ function bigSymbolsReport() {
cell.append('span').text(treemap.pathFor(record)); cell.append('span').text(treemap.pathFor(record));
cell.append('br'); cell.append('br');
cell.append('span').text('Symbol: '); cell.append('span').text('Symbol: ');
cell.append('span').text(escape(record.n)); cell.append('span').text(record.n);
} else { } else {
var href = 'https://code.google.com/p/chromium/codesearch#chromium/src' var href = 'https://code.google.com/p/chromium/codesearch#chromium/src'
+ treemap.pathFor(record) + treemap.pathFor(record)
+ '&q=' + '&q='
+ escape(record.n); + record.n;
cell.append('a') cell.append('a')
.attr('href', href) .attr('href', href)
.attr('target', '_blank') .attr('target', '_blank')
.text(escape(treemap.pathFor(record))); .text(treemap.pathFor(record));
cell.append('br'); cell.append('br');
cell.append('span').text('Symbol: '); cell.append('span').text('Symbol: ');
cell.append('span').text(escape(record.n)); cell.append('span').text(record.n);
} }
} }
}; };
...@@ -174,7 +174,7 @@ function bigPathsReport() { ...@@ -174,7 +174,7 @@ function bigPathsReport() {
cell.append('a') cell.append('a')
.attr('href', href) .attr('href', href)
.attr('target', '_blank') .attr('target', '_blank')
.text(escape(treemap.pathFor(record))); .text(treemap.pathFor(record));
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment