[LayoutNG] Place InlineFlowBox from NGFragment tree

NGInlineNode::CopyFragmentDataToLayoutBox copies geometry from inline
NGFragment tree to RootInlineBox and InlineTextBox, but didn't include
InlineFlowBox. This results in InlineFlowBox, generated for nested
inline elements, to have (0,0). Their children are placed, but since
parent InlineFlowBox is at (0,0), they were clipped.

This fix turns several tests to fail. They used to pass because expected
images did not render. This fix unhides such tests.

BUG=636993, 723117
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2887623002
Cr-Commit-Position: refs/heads/master@{#473444}

third_party/WebKit/LayoutTests/TestExpectations

@@ -344,8 +344,6 @@ crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-109
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-110.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-113.xht [ Skip ]
 crbug.com/719620 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-114.xht [ Skip ]
-crbug.com/723117 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-124.xht [ Skip ]
-crbug.com/723117 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-125.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-126.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-127.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-128.xht [ Skip ]
@@ -363,6 +361,7 @@ crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-143
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-144.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-145.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-146.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-153.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-bfc-001.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/floats-bfc-002.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/floats-clear/margin-collapse-018.xht [ Skip ]
@@ -627,8 +626,16 @@ crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/abspos/abspos-containin
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-formatting-context-height-001.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-formatting-context-height-002.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-formatting-contexts-015.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-001a.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-001f.xht [ Skip ]
 crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-002f.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-003.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-004.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-007.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-008a.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-009.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-010.xht [ Skip ]
+crbug.com/635619 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-insert-011.xht [ Skip ]
 crbug.com/719646 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-margins-001a.xht [ Skip ]
 crbug.com/719646 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-margins-001b.xht [ Skip ]
 crbug.com/719646 virtual/layout_ng/external/wpt/css/CSS2/normal-flow/block-in-inline-margins-002a.xht [ Skip ]

third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

@@ -31,6 +31,34 @@
 
 namespace blink {
 
+namespace {
+
+// Set the geometry to InlineFlowBox by computing the union of children.
+void PlaceInlineFlowBoxes(InlineFlowBox* flow_box) {
+  LayoutUnit logical_left = LayoutUnit::Max();
+  LayoutUnit logical_right = LayoutUnit::Min();
+  LayoutUnit logical_top = LayoutUnit::Max();
+  for (InlineBox* curr = flow_box->FirstChild(); curr;
+       curr = curr->NextOnLine()) {
+    if (curr->GetLineLayoutItem().IsLayoutInline()) {
+      InlineFlowBox* flow = ToInlineFlowBox(curr);
+      PlaceInlineFlowBoxes(flow);
+    }
+    logical_left = std::min(curr->LogicalLeft(), logical_left);
+    logical_right = std::max(curr->LogicalRight(), logical_right);
+    logical_top = std::min(curr->LogicalTop(), logical_top);
+  }
+  if (logical_left == LayoutUnit::Max())
+    return;
+  logical_left -= flow_box->MarginBorderPaddingLogicalLeft();
+  logical_right += flow_box->MarginBorderPaddingLogicalRight();
+  flow_box->SetLogicalLeft(logical_left);
+  flow_box->SetLogicalWidth(logical_right - logical_left);
+  flow_box->SetLogicalTop(logical_top);
+}
+
+}  // namespace
+
 NGInlineNode::NGInlineNode(LayoutObject* start_inline, LayoutNGBlockFlow* block)
     : NGLayoutInputNode(NGLayoutInputNodeType::kLegacyInline),
       start_inline_(start_inline),
@@ -358,6 +386,10 @@ void NGInlineNode::CopyFragmentDataToLayoutBox(
     }
     DCHECK(!run);
 
+    // InlineTextBox and InlineBox are placed, but when ConstructLine() created
+    // InlineFlowBox, they needed to be placed as well.
+    PlaceInlineFlowBoxes(root_line_box);
+
     // Copy to RootInlineBox.
     NGLineBoxFragment line_box(constraint_space.WritingMode(),
                                physical_line_box);