Delete unused enterprise reporting pref

Those prefs values are set by policies only. |kCloudReportingEnabled|
was moved to local_state a while ago while the other policies are never
launched.

Bug: 1107440
Change-Id: Ie0c9ff83ac4ef5e9f950a4d446c16f687fbffac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360570Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804431}

chrome/browser/extensions/BUILD.gn

@@ -1083,8 +1083,6 @@ static_library("extensions") {
       "api/enterprise_reporting_private/enterprise_reporting_private_api.h",
       "api/enterprise_reporting_private/keychain_data_helper_mac.h",
       "api/enterprise_reporting_private/keychain_data_helper_mac.mm",
-      "api/enterprise_reporting_private/prefs.cc",
-      "api/enterprise_reporting_private/prefs.h",
       "api/image_writer_private/operation_nonchromeos.cc",
       "api/messaging/native_message_process_host.cc",
       "api/messaging/native_message_process_host.h",

chrome/browser/extensions/api/enterprise_reporting_private/prefs.cc

-// Copyright 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/api/enterprise_reporting_private/prefs.h"
-
-#include "chrome/common/pref_names.h"
-#include "components/enterprise/browser/reporting/common_pref_names.h"
-#include "components/pref_registry/pref_registry_syncable.h"
-
-namespace extensions {
-namespace enterprise_reporting {
-
-const char kReportVersionData[] = "enterprise_reporting.report_version_data";
-
-const char kReportPolicyData[] = "enterprise_reporting.report_policy_data";
-
-const char kReportMachineIDData[] =
-    "enterprise_reporting.report_machine_id_data";
-
-const char kReportUserIDData[] = "enterprise_reporting.report_user_id_data";
-
-const char kReportExtensionsAndPluginsData[] =
-    "enterprise_reporting.report_extensions_and_plugins_data";
-
-const char kReportSafeBrowsingData[] =
-    "enterprise_reporting.report_safe_browsing_data";
-
-void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
-  registry->RegisterBooleanPref(kReportVersionData, true);
-  registry->RegisterBooleanPref(kReportPolicyData, true);
-  registry->RegisterBooleanPref(kReportMachineIDData, true);
-  registry->RegisterBooleanPref(kReportUserIDData, true);
-  registry->RegisterBooleanPref(kReportExtensionsAndPluginsData, true);
-  registry->RegisterBooleanPref(kReportSafeBrowsingData, false);
-  registry->RegisterBooleanPref(::enterprise_reporting::kCloudReportingEnabled,
-                                false);
-}
-
-}  // namespace enterprise_reporting
-}  // namespace extensions

chrome/browser/extensions/api/enterprise_reporting_private/prefs.h

-// Copyright 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_REPORTING_PRIVATE_PREFS_H_
-#define CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_REPORTING_PRIVATE_PREFS_H_
-
-namespace user_prefs {
-class PrefRegistrySyncable;
-}  // namespace user_prefs
-
-namespace extensions {
-namespace enterprise_reporting {
-
-// Controls reporting of OS/Chrome version information.
-extern const char kReportVersionData[];
-
-// Controls reporting of Chrome policy data and policy fetch timestamps.
-extern const char kReportPolicyData[];
-
-// Controls reporting of information that can identify machines.
-extern const char kReportMachineIDData[];
-
-// Controls reporting of information that can identify users.
-extern const char kReportUserIDData[];
-
-// Controls reporting of Chrome extensions and plugins data.
-extern const char kReportExtensionsAndPluginsData[];
-
-// Controls reporting of Safe browsing data.
-extern const char kReportSafeBrowsingData[];
-
-void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
-
-}  // namespace enterprise_reporting
-}  // namespace extensions
-
-#endif  // CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_REPORTING_PRIVATE_PREFS_H_

chrome/browser/policy/configuration_policy_handler_list_factory.cc

@@ -146,10 +146,6 @@
 #include "extensions/common/manifest.h"
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
-#if BUILDFLAG(ENABLE_EXTENSIONS) && !defined(OS_CHROMEOS)
-#include "chrome/browser/extensions/api/enterprise_reporting_private/prefs.h"
-#endif  // BUILDFLAG(ENABLE_EXTENSIONS) && !defined(OS_CHROMEOS)
-
 #if BUILDFLAG(ENABLE_PLUGINS)
 #include "chrome/browser/plugins/plugin_policy_handler.h"
 #endif  // BUILDFLAG(ENABLE_PLUGINS)
@@ -1270,24 +1266,6 @@ const PolicyToPreferenceMapEntry kSimplePolicyMap[] = {
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
 #if !defined(OS_CHROMEOS) && BUILDFLAG(ENABLE_EXTENSIONS)
-  { key::kReportVersionData,
-    extensions::enterprise_reporting::kReportVersionData,
-    base::Value::Type::BOOLEAN },
-  { key::kReportPolicyData,
-    extensions::enterprise_reporting::kReportPolicyData,
-    base::Value::Type::BOOLEAN },
-  { key::kReportMachineIDData,
-    extensions::enterprise_reporting::kReportMachineIDData,
-    base::Value::Type::BOOLEAN },
-  { key::kReportUserIDData,
-    extensions::enterprise_reporting::kReportUserIDData,
-    base::Value::Type::BOOLEAN },
-  { key::kReportExtensionsAndPluginsData,
-    extensions::enterprise_reporting::kReportExtensionsAndPluginsData,
-    base::Value::Type::BOOLEAN },
-  { key::kReportSafeBrowsingData,
-    extensions::enterprise_reporting::kReportSafeBrowsingData,
-    base::Value::Type::BOOLEAN },
   { key::kBlockExternalExtensions,
     extensions::pref_names::kBlockExternalExtensions,
     base::Value::Type::BOOLEAN },

chrome/browser/prefs/browser_prefs.cc

@@ -185,8 +185,6 @@
 #include "chrome/browser/chromeos/policy/system_proxy_manager.h"
 #include "chrome/browser/chromeos/settings/stats_reporting_controller.h"
 #include "chrome/browser/component_updater/metadata_table_chromeos.h"
-#else
-#include "chrome/browser/extensions/api/enterprise_reporting_private/prefs.h"
 #endif  // defined(OS_CHROMEOS)
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
@@ -1132,10 +1130,6 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
   default_apps::RegisterProfilePrefs(registry);
 #endif
 
-#if !defined(OS_CHROMEOS) && BUILDFLAG(ENABLE_EXTENSIONS)
-  extensions::enterprise_reporting::RegisterProfilePrefs(registry);
-#endif
-
 #if defined(TOOLKIT_VIEWS)
   accessibility_prefs::RegisterInvertBubbleUserPrefs(registry);
   RegisterBrowserViewProfilePrefs(registry);

chrome/test/data/policy/policy_test_cases.json

@@ -7300,65 +7300,15 @@
     ]
   },
 
-  "ReportVersionData": {
-    "os": ["win", "linux", "mac"],
-    "policy_pref_mapping_test": [
-      {
-        "policies": {
-          "ReportVersionData": false
-        },
-        "prefs": { "enterprise_reporting.report_version_data": {} }
-      }
-    ]
-  },
+  "ReportVersionData": {},
 
-  "ReportPolicyData": {
-    "os": ["win", "linux", "mac"],
-    "policy_pref_mapping_test": [
-      {
-        "policies": {
-          "ReportPolicyData": false
-        },
-        "prefs": { "enterprise_reporting.report_policy_data": {} }
-      }
-    ]
-  },
+  "ReportPolicyData": {},
 
-  "ReportMachineIDData": {
-    "os": ["win", "linux", "mac"],
-    "policy_pref_mapping_test": [
-      {
-        "policies": {
-          "ReportMachineIDData": false
-        },
-        "prefs": { "enterprise_reporting.report_machine_id_data": {} }
-      }
-    ]
-  },
+  "ReportMachineIDData": {},
 
-  "ReportUserIDData": {
-    "os": ["win", "linux", "mac"],
-    "policy_pref_mapping_test": [
-      {
-        "policies": {
-          "ReportUserIDData": false
-        },
-        "prefs": { "enterprise_reporting.report_user_id_data": {} }
-      }
-    ]
-  },
+  "ReportUserIDData": {},
 
-  "ReportExtensionsAndPluginsData": {
-    "os": ["win", "linux", "mac"],
-    "policy_pref_mapping_test": [
-      {
-        "policies": {
-          "ReportExtensionsAndPluginsData": false
-        },
-        "prefs": { "enterprise_reporting.report_extensions_and_plugins_data": {} }
-      }
-    ]
-  },
+  "ReportExtensionsAndPluginsData": {},
 
   "ReportSafeBrowsingData": {
     "note": "This policy has been removed. See https://bugs.chromium.org/p/chromium/issues/detail?id=1083085"