Attempt to fix crash in Assistant UI close sequence.
I was unable to reproduce the crash, but based on the stack trace in crbug/952996, my understanding of the cause is: (1) User attempts to close Assistant UI via caption bar while animation is in progress. (2) This triggers an animation abort to occur which fires an animation ended callback in UiElementContainerView. (3) UiElementContainerView currently only handles the case where an animation end occurs due to a new Assistant response being queued for display. (4) We attempt to access the queued Assistant response and crash. Since (1) will ultimately result in the entire Assistant view hierarchy being destroyed, the cleanest way to handle this is to just prevent (3) - (4) from accessing invalid state. Bug: 952996 Change-Id: I056df562a21f18ae032beaeb46fc637ecef21c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574743Reviewed-by:Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652668}
Showing
Please register or sign in to comment