Commit 1df4d968 authored by Trevor Perrier's avatar Trevor Perrier Committed by Commit Bot

[Android] Add flags for Clank language decouple

This CL adds just the feature flag for the Clank language decouple.  Three
more CLs will add the rest of the feature.

The feature flag DETAILED_LANGUAGE_SETTINGS is added to be used for both
the initial language decuple and new Android language settings.

Bug: 1068667
Change-Id: I9e999f44e6f431bb1f13d16f170d626f8819db45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360591Reviewed-by: default avatarDavid Vallet <dvallet@chromium.org>
Reviewed-by: default avatarMegan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802438}
parent 73a9afec
...@@ -231,6 +231,7 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -231,6 +231,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&net::features::kCookiesWithoutSameSiteMustBeSecure, &net::features::kCookiesWithoutSameSiteMustBeSecure,
&paint_preview::kPaintPreviewDemo, &paint_preview::kPaintPreviewDemo,
&paint_preview::kPaintPreviewShowOnStartup, &paint_preview::kPaintPreviewShowOnStartup,
&language::kDetailedLanguageSettings,
&language::kExplicitLanguageAsk, &language::kExplicitLanguageAsk,
&ntp_snippets::kArticleSuggestionsFeature, &ntp_snippets::kArticleSuggestionsFeature,
&offline_pages::kOfflineIndicatorFeature, &offline_pages::kOfflineIndicatorFeature,
......
...@@ -280,6 +280,7 @@ public abstract class ChromeFeatureList { ...@@ -280,6 +280,7 @@ public abstract class ChromeFeatureList {
"DarkenWebsitesCheckboxInThemesSetting"; "DarkenWebsitesCheckboxInThemesSetting";
public static final String DECOUPLE_SYNC_FROM_ANDROID_MASTER_SYNC = public static final String DECOUPLE_SYNC_FROM_ANDROID_MASTER_SYNC =
"DecoupleSyncFromAndroidMasterSync"; "DecoupleSyncFromAndroidMasterSync";
public static final String DETAILED_LANGUAGE_SETTINGS = "DetailedLanguageSettings";
public static final String DIRECT_ACTIONS = "DirectActions"; public static final String DIRECT_ACTIONS = "DirectActions";
public static final String DNS_OVER_HTTPS = "DnsOverHttps"; public static final String DNS_OVER_HTTPS = "DnsOverHttps";
public static final String DOWNLOAD_FILE_PROVIDER = "DownloadFileProvider"; public static final String DOWNLOAD_FILE_PROVIDER = "DownloadFileProvider";
......
...@@ -30,6 +30,8 @@ const base::Feature kUseFluentLanguageModel { ...@@ -30,6 +30,8 @@ const base::Feature kUseFluentLanguageModel {
}; };
const base::Feature kNotifySyncOnLanguageDetermined{ const base::Feature kNotifySyncOnLanguageDetermined{
"NotifySyncOnLanguageDetermined", base::FEATURE_ENABLED_BY_DEFAULT}; "NotifySyncOnLanguageDetermined", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kDetailedLanguageSettings{
"DetailedLanguageSettings", base::FEATURE_DISABLED_BY_DEFAULT};
// Params: // Params:
const char kBackoffThresholdKey[] = "backoff_threshold"; const char kBackoffThresholdKey[] = "backoff_threshold";
......
...@@ -36,6 +36,9 @@ extern const base::Feature kNotifySyncOnLanguageDetermined; ...@@ -36,6 +36,9 @@ extern const base::Feature kNotifySyncOnLanguageDetermined;
// This feature uses the existing UI for translate bubble. // This feature uses the existing UI for translate bubble.
extern const base::Feature kUseButtonTranslateBubbleUi; extern const base::Feature kUseButtonTranslateBubbleUi;
// This feature enables setting the application language on Android.
extern const base::Feature kDetailedLanguageSettings;
enum class OverrideLanguageModel { enum class OverrideLanguageModel {
DEFAULT, DEFAULT,
FLUENT, FLUENT,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment