Commit 1e30c067 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove WebAssociatedURLLoaderClient.DidReceiveCachedMetadata

No one implements the method in a meaningful way.

Bug: None
Change-Id: I5eb3ca12ef4dd904e680a108bd1c1156414a6dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528783Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarK. Moon <kmoon@chromium.org>
Reviewed-by: default avatarJohn Rummell <jrummell@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826662}
parent f31b84ec
...@@ -425,12 +425,6 @@ void ResourceMultiBufferDataProvider::DidDownloadData(uint64_t dataLength) { ...@@ -425,12 +425,6 @@ void ResourceMultiBufferDataProvider::DidDownloadData(uint64_t dataLength) {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
} }
void ResourceMultiBufferDataProvider::DidReceiveCachedMetadata(
const char* data,
int data_length) {
NOTIMPLEMENTED();
}
void ResourceMultiBufferDataProvider::DidFinishLoading() { void ResourceMultiBufferDataProvider::DidFinishLoading() {
DVLOG(1) << "didFinishLoading"; DVLOG(1) << "didFinishLoading";
DCHECK(active_loader_.get()); DCHECK(active_loader_.get());
......
...@@ -56,7 +56,6 @@ class MEDIA_BLINK_EXPORT ResourceMultiBufferDataProvider ...@@ -56,7 +56,6 @@ class MEDIA_BLINK_EXPORT ResourceMultiBufferDataProvider
void DidReceiveResponse(const blink::WebURLResponse& response) override; void DidReceiveResponse(const blink::WebURLResponse& response) override;
void DidDownloadData(uint64_t data_length) override; void DidDownloadData(uint64_t data_length) override;
void DidReceiveData(const char* data, int data_length) override; void DidReceiveData(const char* data, int data_length) override;
void DidReceiveCachedMetadata(const char* data, int dataLength) override;
void DidFinishLoading() override; void DidFinishLoading() override;
void DidFail(const blink::WebURLError&) override; void DidFail(const blink::WebURLError&) override;
......
...@@ -243,12 +243,6 @@ void BlinkUrlLoader::DidReceiveData(const char* data, int data_length) { ...@@ -243,12 +243,6 @@ void BlinkUrlLoader::DidReceiveData(const char* data, int data_length) {
RunReadCallback(); RunReadCallback();
} }
void BlinkUrlLoader::DidReceiveCachedMetadata(const char* data,
int data_length) {
// Doesn't apply to PDF viewer requests.
NOTREACHED();
}
// Modeled on `content::PepperURLLoaderHost::DidFinishLoading()`. // Modeled on `content::PepperURLLoaderHost::DidFinishLoading()`.
void BlinkUrlLoader::DidFinishLoading() { void BlinkUrlLoader::DidFinishLoading() {
DCHECK_EQ(state_, LoadingState::kStreamingData); DCHECK_EQ(state_, LoadingState::kStreamingData);
......
...@@ -177,7 +177,6 @@ class BlinkUrlLoader final : public UrlLoader, ...@@ -177,7 +177,6 @@ class BlinkUrlLoader final : public UrlLoader,
void DidReceiveResponse(const blink::WebURLResponse& response) override; void DidReceiveResponse(const blink::WebURLResponse& response) override;
void DidDownloadData(uint64_t data_length) override; void DidDownloadData(uint64_t data_length) override;
void DidReceiveData(const char* data, int data_length) override; void DidReceiveData(const char* data, int data_length) override;
void DidReceiveCachedMetadata(const char* data, int data_length) override;
void DidFinishLoading() override; void DidFinishLoading() override;
void DidFail(const blink::WebURLError& error) override; void DidFail(const blink::WebURLError& error) override;
......
...@@ -22,7 +22,6 @@ class WebAssociatedURLLoaderClient { ...@@ -22,7 +22,6 @@ class WebAssociatedURLLoaderClient {
virtual void DidReceiveResponse(const WebURLResponse&) {} virtual void DidReceiveResponse(const WebURLResponse&) {}
virtual void DidDownloadData(uint64_t data_length) {} virtual void DidDownloadData(uint64_t data_length) {}
virtual void DidReceiveData(const char* data, int data_length) {} virtual void DidReceiveData(const char* data, int data_length) {}
virtual void DidReceiveCachedMetadata(const char* data, int data_length) {}
virtual void DidFinishLoading() {} virtual void DidFinishLoading() {}
virtual void DidFail(const WebURLError&) {} virtual void DidFail(const WebURLError&) {}
......
...@@ -115,7 +115,6 @@ class WebAssociatedURLLoaderImpl::ClientAdapter final ...@@ -115,7 +115,6 @@ class WebAssociatedURLLoaderImpl::ClientAdapter final
void DidReceiveResponse(uint64_t, const ResourceResponse&) override; void DidReceiveResponse(uint64_t, const ResourceResponse&) override;
void DidDownloadData(uint64_t /*dataLength*/) override; void DidDownloadData(uint64_t /*dataLength*/) override;
void DidReceiveData(const char*, unsigned /*dataLength*/) override; void DidReceiveData(const char*, unsigned /*dataLength*/) override;
void DidReceiveCachedMetadata(const char*, int /*dataLength*/) override;
void DidFinishLoading(uint64_t /*identifier*/) override; void DidFinishLoading(uint64_t /*identifier*/) override;
void DidFail(const ResourceError&) override; void DidFail(const ResourceError&) override;
void DidFailRedirectCheck() override; void DidFailRedirectCheck() override;
...@@ -256,15 +255,6 @@ void WebAssociatedURLLoaderImpl::ClientAdapter::DidReceiveData( ...@@ -256,15 +255,6 @@ void WebAssociatedURLLoaderImpl::ClientAdapter::DidReceiveData(
client_->DidReceiveData(data, data_length); client_->DidReceiveData(data, data_length);
} }
void WebAssociatedURLLoaderImpl::ClientAdapter::DidReceiveCachedMetadata(
const char* data,
int data_length) {
if (!client_)
return;
client_->DidReceiveCachedMetadata(data, data_length);
}
void WebAssociatedURLLoaderImpl::ClientAdapter::DidFinishLoading( void WebAssociatedURLLoaderImpl::ClientAdapter::DidFinishLoading(
uint64_t identifier) { uint64_t identifier) {
if (!client_) if (!client_)
......
...@@ -66,7 +66,6 @@ class WebAssociatedURLLoaderTest : public testing::Test, ...@@ -66,7 +66,6 @@ class WebAssociatedURLLoaderTest : public testing::Test,
did_send_data_(false), did_send_data_(false),
did_receive_response_(false), did_receive_response_(false),
did_receive_data_(false), did_receive_data_(false),
did_receive_cached_metadata_(false),
did_finish_loading_(false), did_finish_loading_(false),
did_fail_(false) { did_fail_(false) {
// Reuse one of the test files from WebFrameTest. // Reuse one of the test files from WebFrameTest.
...@@ -158,10 +157,6 @@ class WebAssociatedURLLoaderTest : public testing::Test, ...@@ -158,10 +157,6 @@ class WebAssociatedURLLoaderTest : public testing::Test,
EXPECT_GT(data_length, 0); EXPECT_GT(data_length, 0);
} }
void DidReceiveCachedMetadata(const char* data, int data_length) override {
did_receive_cached_metadata_ = true;
}
void DidFinishLoading() override { did_finish_loading_ = true; } void DidFinishLoading() override { did_finish_loading_ = true; }
void DidFail(const WebURLError& error) override { did_fail_ = true; } void DidFail(const WebURLError& error) override { did_fail_ = true; }
...@@ -267,7 +262,6 @@ class WebAssociatedURLLoaderTest : public testing::Test, ...@@ -267,7 +262,6 @@ class WebAssociatedURLLoaderTest : public testing::Test,
bool did_receive_response_; bool did_receive_response_;
bool did_download_data_; bool did_download_data_;
bool did_receive_data_; bool did_receive_data_;
bool did_receive_cached_metadata_;
bool did_finish_loading_; bool did_finish_loading_;
bool did_fail_; bool did_fail_;
}; };
......
...@@ -66,10 +66,6 @@ class MultiResolutionImageResourceFetcher::ClientImpl ...@@ -66,10 +66,6 @@ class MultiResolutionImageResourceFetcher::ClientImpl
DCHECK(!completed_); DCHECK(!completed_);
response_ = response; response_ = response;
} }
void DidReceiveCachedMetadata(const char* data, int data_length) override {
DCHECK(!completed_);
DCHECK_GT(data_length, 0);
}
void DidReceiveData(const char* data, int data_length) override { void DidReceiveData(const char* data, int data_length) override {
// The WebAssociatedURLLoader will continue after a load failure. // The WebAssociatedURLLoader will continue after a load failure.
// For example, for an Access Control error. // For example, for an Access Control error.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment