Fix drag and drop reentrant crash
DragDropController::Drop() can be reentrant since exo::DataDevice creates a nested RunLoop (crbug.com/1141745), and referencing |drag_data_| after it has been moved causes a crash. This is fixed by checking |!!drag_data_| in IsDragDropInProgress(). Bug: 1141745 Change-Id: Ide2b376d2b6d8dff3ba820c308e1cc1faffbe7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494189Reviewed-by:Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#820402}
Showing
Please register or sign in to comment