Commit 1e53d034 authored by avi's avatar avi Committed by Commit bot

Replace page id for updating the history offset.

BUG=369661
TEST=All navigation tests remain green.

Review URL: https://codereview.chromium.org/1131183004

Cr-Commit-Position: refs/heads/master@{#329699}
parent e0e4abeb
...@@ -2706,18 +2706,14 @@ void RenderFrameImpl::didCommitProvisionalLoad( ...@@ -2706,18 +2706,14 @@ void RenderFrameImpl::didCommitProvisionalLoad(
} else { } else {
const RequestNavigationParams& request_params = const RequestNavigationParams& request_params =
navigation_state->request_params(); navigation_state->request_params();
if (request_params.page_id != -1) { if (request_params.nav_entry_id != 0 &&
!request_params.intended_as_new_entry) {
// This is a successful session history navigation! // This is a successful session history navigation!
render_view_->page_id_ = request_params.page_id; render_view_->page_id_ = request_params.page_id;
render_view_->history_list_offset_ = render_view_->history_list_offset_ =
request_params.pending_history_list_offset; request_params.pending_history_list_offset;
} }
// Page id is going away (http://crbug.com/369661); ensure that a
// replacement that doesn't use page id is equivalent in all cases.
CHECK_EQ(request_params.page_id != -1,
request_params.nav_entry_id != 0 &&
!request_params.intended_as_new_entry);
} }
bool sent = Send( bool sent = Send(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment