Commit 1e54f71e authored by Chris Harrelson's avatar Chris Harrelson Committed by Commit Bot

[PE] Don't call CompositedScrollsWithRespectTo during raster invalidation

It is redundant with the call to UsesCompositedScrolling just below, and
is equivalent to UsesCompositedScrolling + object != paint_invalidation_container.
UsesCompositedScrolling calls two methods plus a virtual, so may be slow.

Bug: 818709

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iab617e3941563ac1994e5732359cf691442a2b7e
Reviewed-on: https://chromium-review.googlesource.com/959444
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542667}
parent f018c9b2
...@@ -308,13 +308,10 @@ void ObjectPaintInvalidator::SetBackingNeedsPaintInvalidationInRect( ...@@ -308,13 +308,10 @@ void ObjectPaintInvalidator::SetBackingNeedsPaintInvalidationInRect(
squashing_layer->SetNeedsDisplayInRect(EnclosingIntRect(rect), reason, squashing_layer->SetNeedsDisplayInRect(EnclosingIntRect(rect), reason,
object_); object_);
} }
} else if (object_.CompositedScrollsWithRespectTo(
paint_invalidation_container)) {
layer.GetCompositedLayerMapping()->SetScrollingContentsNeedDisplayInRect(
rect, reason, object_);
} else if (paint_invalidation_container.UsesCompositedScrolling()) { } else if (paint_invalidation_container.UsesCompositedScrolling()) {
DCHECK(object_ == paint_invalidation_container); // If object_ is not paint_invalidation_container, then it scrolls.
if (reason == if (&object_ != paint_invalidation_container ||
reason ==
PaintInvalidationReason::kBackgroundOnScrollingContentsLayer || PaintInvalidationReason::kBackgroundOnScrollingContentsLayer ||
reason == PaintInvalidationReason::kCaret) { reason == PaintInvalidationReason::kCaret) {
layer.GetCompositedLayerMapping()->SetScrollingContentsNeedDisplayInRect( layer.GetCompositedLayerMapping()->SetScrollingContentsNeedDisplayInRect(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment