[PwdCheckAndroid] Don't update the UI model if the check gets cancelled

This status only gets sent when the UI and bridge are being torn down
while a check is running. At this point, no UI update is needed.

Bug: 1121145
Change-Id: I0a413da4432d346a07f7252263c2626ae93aadac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377865Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801752}

chrome/browser/password_check/android/internal/java/src/org/chromium/chrome/browser/password_check/PasswordCheckMediator.java

@@ -108,6 +108,9 @@ class PasswordCheckMediator
 
     @Override
     public void onPasswordCheckStatusChanged(@PasswordCheckUIStatus int status) {
+        // There is no UI representation of a canceled check. This status can be sent when
+        // the bridge and the password check UI are being torn down while a check is running.
+        if (status == PasswordCheckUIStatus.CANCELED) return;
         ListModel<ListItem> items = mModel.get(ITEMS);
         PropertyModel header;
         if (items.size() == 0) {

chrome/browser/password_check/android/junit/src/org/chromium/chrome/browser/password_check/PasswordCheckControllerTest.java

@@ -32,6 +32,7 @@ import static org.chromium.chrome.browser.password_check.PasswordCheckProperties
 import static org.chromium.chrome.browser.password_check.PasswordCheckProperties.HeaderProperties.RESTART_BUTTON_ACTION;
 import static org.chromium.chrome.browser.password_check.PasswordCheckProperties.HeaderProperties.UNKNOWN_PROGRESS;
 import static org.chromium.chrome.browser.password_check.PasswordCheckProperties.ITEMS;
+import static org.chromium.chrome.browser.password_check.PasswordCheckUIStatus.CANCELED;
 import static org.chromium.chrome.browser.password_check.PasswordCheckUIStatus.ERROR_OFFLINE;
 import static org.chromium.chrome.browser.password_check.PasswordCheckUIStatus.ERROR_UNKNOWN;
 import static org.chromium.chrome.browser.password_check.PasswordCheckUIStatus.IDLE;
@@ -283,6 +284,14 @@ public class PasswordCheckControllerTest {
         assertThat(mModel.get(ITEMS).get(0).model.get(COMPROMISED_CREDENTIALS_COUNT), is(2));
     }
 
+    @Test
+    public void testCanceledStatusDoesntUpdateModel() {
+        assertRunningHeader(mModel.get(ITEMS).get(0), UNKNOWN_PROGRESS);
+        mMediator.onPasswordCheckStatusChanged(CANCELED);
+        // Check that the header model didn't change.
+        assertRunningHeader(mModel.get(ITEMS).get(0), UNKNOWN_PROGRESS);
+    }
+
     @Test
     public void testNotIdleStatusNotUpdatedOnCredentialsFetchCompleted() {
         mMediator.onPasswordCheckStatusChanged(RUNNING);