Commit 1e70633d authored by hans@chromium.org's avatar hans@chromium.org

ChromeOS: virtual destructors should have virtual keyword.

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/6992062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86607 0039d316-1c4b-4281-b951-d872f2087c98
parent 45f730cf
...@@ -33,7 +33,7 @@ class BootTimesLoader ...@@ -33,7 +33,7 @@ class BootTimesLoader
public NotificationObserver { public NotificationObserver {
public: public:
BootTimesLoader(); BootTimesLoader();
~BootTimesLoader(); virtual ~BootTimesLoader();
// All fields are 0.0 if they couldn't be found. // All fields are 0.0 if they couldn't be found.
typedef struct BootTimes { typedef struct BootTimes {
......
...@@ -430,7 +430,7 @@ class VirtualNetwork : public Network { ...@@ -430,7 +430,7 @@ class VirtualNetwork : public Network {
}; };
explicit VirtualNetwork(const std::string& service_path); explicit VirtualNetwork(const std::string& service_path);
~VirtualNetwork(); virtual ~VirtualNetwork();
const std::string& server_hostname() const { return server_hostname_; } const std::string& server_hostname() const { return server_hostname_; }
ProviderType provider_type() const { return provider_type_; } ProviderType provider_type() const { return provider_type_; }
......
...@@ -83,7 +83,7 @@ class StartupCustomizationDocument : public CustomizationDocument { ...@@ -83,7 +83,7 @@ class StartupCustomizationDocument : public CustomizationDocument {
StartupCustomizationDocument(SystemAccess* system_access, StartupCustomizationDocument(SystemAccess* system_access,
const std::string& manifest); const std::string& manifest);
~StartupCustomizationDocument(); virtual ~StartupCustomizationDocument();
void Init(SystemAccess* system_access); void Init(SystemAccess* system_access);
...@@ -169,7 +169,7 @@ class ServicesCustomizationDocument : public CustomizationDocument, ...@@ -169,7 +169,7 @@ class ServicesCustomizationDocument : public CustomizationDocument,
ServicesCustomizationDocument(const std::string& manifest, ServicesCustomizationDocument(const std::string& manifest,
const std::string& initial_locale); const std::string& initial_locale);
~ServicesCustomizationDocument(); virtual ~ServicesCustomizationDocument();
// Save applied state in machine settings. // Save applied state in machine settings.
static void SetApplied(bool val); static void SetApplied(bool val);
......
...@@ -48,7 +48,7 @@ class ExistingUserController : public LoginDisplay::Delegate, ...@@ -48,7 +48,7 @@ class ExistingUserController : public LoginDisplay::Delegate,
public: public:
// All UI initialization is deferred till Init() call. // All UI initialization is deferred till Init() call.
explicit ExistingUserController(LoginDisplayHost* host); explicit ExistingUserController(LoginDisplayHost* host);
~ExistingUserController(); virtual ~ExistingUserController();
// Returns the current existing user controller if it has been created. // Returns the current existing user controller if it has been created.
static ExistingUserController* current_controller() { static ExistingUserController* current_controller() {
......
...@@ -37,7 +37,7 @@ class HelpAppLauncher : public LoginHtmlDialog::Delegate, ...@@ -37,7 +37,7 @@ class HelpAppLauncher : public LoginHtmlDialog::Delegate,
// Parent window is used to show dialog. // Parent window is used to show dialog.
explicit HelpAppLauncher(gfx::NativeWindow parent_window); explicit HelpAppLauncher(gfx::NativeWindow parent_window);
~HelpAppLauncher(); virtual ~HelpAppLauncher();
// Shows specified help topic. // Shows specified help topic.
void ShowHelpTopic(HelpTopic help_topic_id); void ShowHelpTopic(HelpTopic help_topic_id);
......
...@@ -156,7 +156,7 @@ class WideButton : public views::NativeButton { ...@@ -156,7 +156,7 @@ class WideButton : public views::NativeButton {
CorrectNativeButtonFontSize(this); CorrectNativeButtonFontSize(this);
} }
~WideButton() {} virtual ~WideButton() {}
private: private:
virtual gfx::Size GetPreferredSize(); virtual gfx::Size GetPreferredSize();
......
...@@ -41,7 +41,7 @@ class LoginHtmlDialog : public HtmlDialogUIDelegate, ...@@ -41,7 +41,7 @@ class LoginHtmlDialog : public HtmlDialogUIDelegate,
const std::wstring& title, const std::wstring& title,
const GURL& url, const GURL& url,
Style style); Style style);
~LoginHtmlDialog(); virtual ~LoginHtmlDialog();
// Shows created dialog. // Shows created dialog.
void Show(); void Show();
......
...@@ -60,7 +60,7 @@ class UserController : public views::WidgetDelegate, ...@@ -60,7 +60,7 @@ class UserController : public views::WidgetDelegate,
// Creates a UserController for the specified user. // Creates a UserController for the specified user.
UserController(Delegate* delegate, const UserManager::User& user); UserController(Delegate* delegate, const UserManager::User& user);
~UserController(); virtual ~UserController();
// Initializes the UserController, creating the set of windows/controls. // Initializes the UserController, creating the set of windows/controls.
// |index| is the index of this user, and |total_user_count| the total // |index| is the index of this user, and |total_user_count| the total
......
...@@ -51,7 +51,7 @@ class WizardController : public chromeos::ScreenObserver, ...@@ -51,7 +51,7 @@ class WizardController : public chromeos::ScreenObserver,
public: public:
explicit WizardController(chromeos::LoginDisplayHost* host, explicit WizardController(chromeos::LoginDisplayHost* host,
const gfx::Rect& screen_bounds); const gfx::Rect& screen_bounds);
~WizardController(); virtual ~WizardController();
// Returns the default wizard controller if it has been created. // Returns the default wizard controller if it has been created.
static WizardController* default_controller() { static WizardController* default_controller() {
......
...@@ -34,7 +34,7 @@ namespace chromeos { ...@@ -34,7 +34,7 @@ namespace chromeos {
class VersionLoader : public CancelableRequestProvider { class VersionLoader : public CancelableRequestProvider {
public: public:
VersionLoader(); VersionLoader();
~VersionLoader(); virtual ~VersionLoader();
enum VersionFormat { enum VersionFormat {
VERSION_SHORT, VERSION_SHORT,
......
...@@ -49,7 +49,7 @@ class WmMessageListener : public MessageLoopForUI::Observer { ...@@ -49,7 +49,7 @@ class WmMessageListener : public MessageLoopForUI::Observer {
friend struct DefaultSingletonTraits<WmMessageListener>; friend struct DefaultSingletonTraits<WmMessageListener>;
WmMessageListener(); WmMessageListener();
~WmMessageListener(); virtual ~WmMessageListener();
// Invoked when a valid WmIpc::Message is received. // Invoked when a valid WmIpc::Message is received.
void ProcessMessage(const WmIpc::Message& message, GdkWindow* window); void ProcessMessage(const WmIpc::Message& message, GdkWindow* window);
......
...@@ -21,7 +21,7 @@ class RenderViewHost; ...@@ -21,7 +21,7 @@ class RenderViewHost;
class ExtensionView : public views::NativeViewHost { class ExtensionView : public views::NativeViewHost {
public: public:
ExtensionView(ExtensionHost* host, Browser* browser); ExtensionView(ExtensionHost* host, Browser* browser);
~ExtensionView(); virtual ~ExtensionView();
// A class that represents the container that this view is in. // A class that represents the container that this view is in.
// (bottom shelf, side bar, etc.) // (bottom shelf, side bar, etc.)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment