Commit 1e81bf1f authored by Dylan Cutler's avatar Dylan Cutler Committed by Commit Bot

Remove use of initializer_list in navigator_plugins.cc.

As dcheng@ pointed out in http://crrev.com/c/2377553 this pattern leads
to inefficient machine code and should not be used here.

Bug: None
Change-Id: I12361f7bc8a6744c6c8ec5dda82bde4ac048dbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392705Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#805345}
parent be12d81d
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
#include "third_party/blink/renderer/modules/plugins/navigator_plugins.h" #include "third_party/blink/renderer/modules/plugins/navigator_plugins.h"
#include <initializer_list>
#include "third_party/blink/public/common/privacy_budget/identifiability_metric_builder.h" #include "third_party/blink/public/common/privacy_budget/identifiability_metric_builder.h"
#include "third_party/blink/public/common/privacy_budget/identifiability_study_settings.h" #include "third_party/blink/public/common/privacy_budget/identifiability_study_settings.h"
#include "third_party/blink/public/common/privacy_budget/identifiable_token_builder.h" #include "third_party/blink/public/common/privacy_budget/identifiable_token_builder.h"
...@@ -63,16 +61,16 @@ void RecordPlugins(LocalFrame* frame, DOMPluginArray* plugins) { ...@@ -63,16 +61,16 @@ void RecordPlugins(LocalFrame* frame, DOMPluginArray* plugins) {
IdentifiableTokenBuilder builder; IdentifiableTokenBuilder builder;
for (unsigned i = 0; i < plugins->length(); i++) { for (unsigned i = 0; i < plugins->length(); i++) {
DOMPlugin* plugin = plugins->item(i); DOMPlugin* plugin = plugins->item(i);
for (const String& token : builder.AddToken(IdentifiabilityBenignStringToken(plugin->name()));
{plugin->name(), plugin->description(), plugin->filename()}) { builder.AddToken(IdentifiabilityBenignStringToken(plugin->description()));
builder.AddToken(IdentifiabilityBenignStringToken(token)); builder.AddToken(IdentifiabilityBenignStringToken(plugin->filename()));
}
for (unsigned j = 0; j < plugin->length(); j++) { for (unsigned j = 0; j < plugin->length(); j++) {
DOMMimeType* mimeType = plugin->item(j); DOMMimeType* mimeType = plugin->item(j);
for (const String& token : {mimeType->type(), mimeType->description(), builder.AddToken(IdentifiabilityBenignStringToken(mimeType->type()));
mimeType->suffixes()}) { builder.AddToken(
builder.AddToken(IdentifiabilityBenignStringToken(token)); IdentifiabilityBenignStringToken(mimeType->description()));
} builder.AddToken(
IdentifiabilityBenignStringToken(mimeType->suffixes()));
} }
} }
IdentifiabilityMetricBuilder(document->UkmSourceID()) IdentifiabilityMetricBuilder(document->UkmSourceID())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment