Commit 1e865bea authored by xhwang's avatar xhwang Committed by Commit bot

media: Add UMA to report media pipeline start result

Recently we see some changes in the pipeline start success rate.
However, we can only get this statistics indirectly through some other
UMAs. This CL adds a UMA directly for this.

Note that if the media pipeline is destroyed during the starting
process, this UMA will NOT be reported. This should be relatively rare.
Also, in this case, the result won't affect user experience anyways.

TEST=Manually tested to make sure the metric is reported.

Review-Url: https://codereview.chromium.org/2383493004
Cr-Commit-Position: refs/heads/master@{#422623}
parent c0d25adc
...@@ -753,6 +753,11 @@ void PipelineImpl::RendererWrapper::CompleteSeek(base::TimeDelta seek_time, ...@@ -753,6 +753,11 @@ void PipelineImpl::RendererWrapper::CompleteSeek(base::TimeDelta seek_time,
DCHECK(media_task_runner_->BelongsToCurrentThread()); DCHECK(media_task_runner_->BelongsToCurrentThread());
DCHECK(state_ == kStarting || state_ == kSeeking || state_ == kResuming); DCHECK(state_ == kStarting || state_ == kSeeking || state_ == kResuming);
if (state_ == kStarting) {
UMA_HISTOGRAM_ENUMERATION("Media.PipelineStatus.Start", status,
PIPELINE_STATUS_MAX + 1);
}
DCHECK(pending_callbacks_); DCHECK(pending_callbacks_);
pending_callbacks_.reset(); pending_callbacks_.reset();
......
...@@ -23972,6 +23972,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -23972,6 +23972,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary> </summary>
</histogram> </histogram>
<histogram name="Media.PipelineStatus.Start" enum="PipelineStatus">
<owner>xhwang@chromium.org</owner>
<summary>
Status of the media pipeline starting process (including demuxer and
renderer initialization). If the media pipeline is destroyed during the
starting process nothing will be reported, but this should relatively rare.
</summary>
</histogram>
<histogram name="Media.PlayMovies.DelayedAndDroppedFramesPer5Sec" <histogram name="Media.PlayMovies.DelayedAndDroppedFramesPer5Sec"
units="frames/5s"> units="frames/5s">
<obsolete> <obsolete>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment