Commit 1e90fe86 authored by thakis@chromium.org's avatar thakis@chromium.org

Disable another racy HostResolverImplTest under tsan.

BUG=268946
TBR=szym@chromium.org

Review URL: https://codereview.chromium.org/135693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244359 0039d316-1c4b-4281-b951-d872f2087c98
parent 5a7bba01
......@@ -621,7 +621,16 @@ TEST_F(HostResolverImplTest, EmptyHost) {
EXPECT_EQ(ERR_NAME_NOT_RESOLVED, req->Resolve());
}
TEST_F(HostResolverImplTest, EmptyDotsHost) {
#if defined(THREAD_SANITIZER)
// There's a data race in this test that may lead to use-after-free.
// If the test starts to crash without ThreadSanitizer it needs to be disabled
// globally. See http://crbug.com/268946 (stacks for this test in
// crbug.com/333567).
#define MAYBE_EmptyDotsHost DISABLED_EmptyDotsHost
#else
#define MAYBE_EmptyDotsHost EmptyDotsHost
#endif
TEST_F(HostResolverImplTest, MAYBE_EmptyDotsHost) {
for (int i = 0; i < 16; ++i) {
Request* req = CreateRequest(std::string(i, '.'), 5555);
EXPECT_EQ(ERR_NAME_NOT_RESOLVED, req->Resolve());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment