Commit 1ea192a5 authored by msw@chromium.org's avatar msw@chromium.org

Fix RTL UI extension popup anchoring.

BubbleDelegateView::CreateNonClientFrameView mirrors in RTL.
(arrow horizontal positions/anchoring are flipped in RTL UI)
BrowserActionsContainer::ShowPopup should not do the same.
See before and after pictures at http://crbug.com/150696

BUG=150696
TEST=RTL (--lang=he) UI browser/page action extension popups should be anchored at the top left and shouldn't be cut off.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/168723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251998 0039d316-1c4b-4281-b951-d872f2087c98
parent ad2cc604
......@@ -860,12 +860,8 @@ bool BrowserActionsContainer::ShowPopup(
// since buttons can be activated from the overflow menu (chevron). In that
// case we show the popup as originating from the chevron.
View* reference_view = button->parent()->visible() ? button : chevron_;
views::BubbleBorder::Arrow arrow = base::i18n::IsRTL() ?
views::BubbleBorder::TOP_LEFT : views::BubbleBorder::TOP_RIGHT;
popup_ = ExtensionPopup::ShowPopup(popup_url,
browser_,
reference_view,
arrow,
popup_ = ExtensionPopup::ShowPopup(popup_url, browser_, reference_view,
views::BubbleBorder::TOP_RIGHT,
show_action);
popup_->GetWidget()->AddObserver(this);
popup_button_ = button;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment