Commit 1ed453c1 authored by David Bienvenu's avatar David Bienvenu Committed by Commit Bot

Add debugging for installer oom.

Adds base::debug::alias for key_path and value when reading from
windows registry.

Bug: 1106328
Change-Id: Ibb936708ffd8b2ce6b759e61095528db2990a483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304977
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790109}
parent 29f0a116
...@@ -4,8 +4,10 @@ ...@@ -4,8 +4,10 @@
#include "chrome/installer/util/set_reg_value_work_item.h" #include "chrome/installer/util/set_reg_value_work_item.h"
#include "base/debug/alias.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/win/registry.h" #include "base/win/registry.h"
#include "chrome/installer/util/logging_installer.h" #include "chrome/installer/util/logging_installer.h"
...@@ -151,6 +153,13 @@ bool SetRegValueWorkItem::DoImpl() { ...@@ -151,6 +153,13 @@ bool SetRegValueWorkItem::DoImpl() {
if (!size) { if (!size) {
previous_type_ = type; previous_type_ = type;
} else { } else {
// TODO(crbug.com/1106328): Remove after bug is resolved.
DEBUG_ALIAS_FOR_CSTR(key_path_copy, base::WideToUTF8(key_path_).c_str(),
255);
DEBUG_ALIAS_FOR_CSTR(value_name_copy,
base::WideToUTF8(value_name_).c_str(), 200);
base::debug::Alias(&size);
base::debug::Alias(&type);
previous_value_.resize(size); previous_value_.resize(size);
result = key.ReadValue(value_name_.c_str(), &previous_value_[0], &size, result = key.ReadValue(value_name_.c_str(), &previous_value_[0], &size,
&previous_type_); &previous_type_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment