Commit 1ee52fd4 authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Do not activate windows when showing chooser bubbles.

Activating windows allows popunders, and is disallowed in Chromium.
Ensure that we do not activate a window when we show a chooser
bubble.

BUG=838314

Change-Id: I052adb7b4bc37a439961059ab95670edcf85cd69
Reviewed-on: https://chromium-review.googlesource.com/1059451
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559384}
parent 28044cb7
...@@ -37,6 +37,9 @@ void ChooserBubbleUi::CreateAndShow(views::BubbleDialogDelegateView* delegate) { ...@@ -37,6 +37,9 @@ void ChooserBubbleUi::CreateAndShow(views::BubbleDialogDelegateView* delegate) {
gfx::NativeView parent = widget->GetNativeView(); gfx::NativeView parent = widget->GetNativeView();
DCHECK(parent); DCHECK(parent);
delegate->set_parent_window(parent); delegate->set_parent_window(parent);
views::BubbleDialogDelegateView::CreateBubble(delegate)->Show(); if (browser_->window()->IsActive())
views::BubbleDialogDelegateView::CreateBubble(delegate)->Show();
else
views::BubbleDialogDelegateView::CreateBubble(delegate)->ShowInactive();
} }
#endif // !OS_MACOSX || MAC_VIEWS_BROWSER #endif // !OS_MACOSX || MAC_VIEWS_BROWSER
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment