Commit 1efe4d42 authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Give the different KDataFile variables unique prefixes

In the jumbo build experiment (chromium unity builds) there is a
collision between the two different kDataFile strings. This patch
renames them kNetworkErrorDataFile and kTargetsDataFile which also
matches their intended values.

Bug: 746953
Change-Id: Ib9f47fa4d358303c7cdbb65b54b40080521a915d
Reviewed-on: https://chromium-review.googlesource.com/721299Reviewed-by: default avatarBence Béky <bnc@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#509320}
parent 98852aa9
...@@ -37,7 +37,7 @@ ...@@ -37,7 +37,7 @@
#include "content/public/common/url_constants.h" #include "content/public/common/url_constants.h"
#include "net/base/escape.h" #include "net/base/escape.h"
static const char kDataFile[] = "targets-data.json"; static const char kTargetsDataFile[] = "targets-data.json";
static const char kProcessIdField[] = "processId"; static const char kProcessIdField[] = "processId";
static const char kRouteIdField[] = "routeId"; static const char kRouteIdField[] = "routeId";
...@@ -118,7 +118,7 @@ std::unique_ptr<base::DictionaryValue> BuildTargetDescriptor( ...@@ -118,7 +118,7 @@ std::unique_ptr<base::DictionaryValue> BuildTargetDescriptor(
bool HandleRequestCallback(BrowserContext* current_context, bool HandleRequestCallback(BrowserContext* current_context,
const std::string& path, const std::string& path,
const WebUIDataSource::GotDataCallback& callback) { const WebUIDataSource::GotDataCallback& callback) {
if (path != kDataFile) if (path != kTargetsDataFile)
return false; return false;
std::unique_ptr<base::ListValue> rvh_list(new base::ListValue()); std::unique_ptr<base::ListValue> rvh_list(new base::ListValue());
...@@ -204,7 +204,7 @@ AccessibilityUI::AccessibilityUI(WebUI* web_ui) : WebUIController(web_ui) { ...@@ -204,7 +204,7 @@ AccessibilityUI::AccessibilityUI(WebUI* web_ui) : WebUIController(web_ui) {
base::Bind(&HandleRequestCallback, base::Bind(&HandleRequestCallback,
web_ui->GetWebContents()->GetBrowserContext())); web_ui->GetWebContents()->GetBrowserContext()));
html_source->UseGzip({kDataFile}); html_source->UseGzip({kTargetsDataFile});
BrowserContext* browser_context = BrowserContext* browser_context =
web_ui->GetWebContents()->GetBrowserContext(); web_ui->GetWebContents()->GetBrowserContext();
......
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
#include "net/base/net_errors.h" #include "net/base/net_errors.h"
#include "net/log/net_log_util.h" #include "net/log/net_log_util.h"
static const char kDataFile[] = "network-error-data.json"; static const char kNetworkErrorDataFile[] = "network-error-data.json";
static const char kErrorCodeField[] = "errorCode"; static const char kErrorCodeField[] = "errorCode";
static const char kErrorCodesDataName[] = "errorCodes"; static const char kErrorCodesDataName[] = "errorCodes";
static const char kErrorIdField[] = "errorId"; static const char kErrorIdField[] = "errorId";
...@@ -60,7 +60,7 @@ std::unique_ptr<base::ListValue> GetNetworkErrorData() { ...@@ -60,7 +60,7 @@ std::unique_ptr<base::ListValue> GetNetworkErrorData() {
bool HandleRequestCallback(BrowserContext* current_context, bool HandleRequestCallback(BrowserContext* current_context,
const std::string& path, const std::string& path,
const WebUIDataSource::GotDataCallback& callback) { const WebUIDataSource::GotDataCallback& callback) {
if (path != kDataFile) if (path != kNetworkErrorDataFile)
return false; return false;
base::DictionaryValue data; base::DictionaryValue data;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment