Commit 1f326482 authored by David Tseng's avatar David Tseng Committed by Commit Bot

Do not call doDefault for action verb select

In Blink, select (default action verb) often equates with 'click'.

A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select.

ChromeVox calls do default and triggers undesirable side effects.

Bug: 889018
Test: manually on Gmail.
Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a
Reviewed-on: https://chromium-review.googlesource.com/1241843
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594036}
parent 965b45ed
...@@ -432,11 +432,6 @@ Background.prototype = { ...@@ -432,11 +432,6 @@ Background.prototype = {
AutomationPredicate.linkOrControl(node); AutomationPredicate.linkOrControl(node);
}; };
// Always try to give nodes selection.
if (start.defaultActionVerb == chrome.automation.DefaultActionVerb.SELECT) {
start.doDefault();
}
// Next, try to focus the start or end node. // Next, try to focus the start or end node.
if (!AutomationPredicate.structuralContainer(start) && if (!AutomationPredicate.structuralContainer(start) &&
start.state[StateType.FOCUSABLE]) { start.state[StateType.FOCUSABLE]) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment