Commit 1f3e0e2c authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /base/memory/shared_memory_unittest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=meacer@chromium.org

Bug: 925652
Change-Id: I69b3596033c224e332b5d2a119c6fe660ccdf070
Reviewed-on: https://chromium-review.googlesource.com/c/1438403
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626385}
parent cc8d4f5a
......@@ -872,13 +872,13 @@ TEST_P(SharedMemoryTest, MappedId) {
}
#endif // !(defined(OS_MACOSX) && !defined(OS_IOS)
INSTANTIATE_TEST_CASE_P(Default,
SharedMemoryTest,
::testing::Values(Mode::Default));
INSTANTIATE_TEST_SUITE_P(Default,
SharedMemoryTest,
::testing::Values(Mode::Default));
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
INSTANTIATE_TEST_CASE_P(SkipDevShm,
SharedMemoryTest,
::testing::Values(Mode::DisableDevShm));
INSTANTIATE_TEST_SUITE_P(SkipDevShm,
SharedMemoryTest,
::testing::Values(Mode::DisableDevShm));
#endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
#if defined(OS_ANDROID)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment