Commit 1f8953e6 authored by haraken@chromium.org's avatar haraken@chromium.org

Oilpan: Update a comment for the WTF_ANNOTATE_LEAKING_OBJECT_PTR macro in PageMemory

This is a follow-up CL for r173508.

BUG=369429
NOTRY=true

Review URL: https://codereview.chromium.org/278433007

git-svn-id: svn://svn.chromium.org/blink/trunk@173632 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 1b4aedd0
...@@ -277,8 +277,16 @@ private: ...@@ -277,8 +277,16 @@ private:
: m_reserved(reserved) : m_reserved(reserved)
, m_writable(writable) , m_writable(writable)
{ {
// Leak Sanitizer runs before the shutdown sequence runs, and thus PageMemory objects // This annotation is for letting the LeakSanitizer ignore PageMemory objects.
// are reported as leaking. So we annotate to let the Leak Sanitizer ignore PageMemory objects. //
// - The LeakSanitizer runs before the shutdown sequence and reports unreachable memory blocks.
// - The LeakSanitizer only recognizes memory blocks allocated through malloc/new,
// and we need special handling for mapped regions.
// - The PageMemory object is only referenced by a HeapPage<Header> object, which is
// located inside the mapped region, which is not released until the shutdown sequence.
//
// Given the above, we need to explicitly annotate that the LeakSanitizer should ignore
// PageMemory objects.
WTF_ANNOTATE_LEAKING_OBJECT_PTR(this); WTF_ANNOTATE_LEAKING_OBJECT_PTR(this);
ASSERT(reserved.contains(writable)); ASSERT(reserved.contains(writable));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment