Commit 1fa0e8b3 authored by Mason Freed's avatar Mason Freed Committed by Commit Bot

Rebaseline layout tests with FormControlsRefresh enabled (CL 4-1)

The [1] CL enabled the FormControlsRefresh feature by default for
Windows, Linux, and ChromeOS. In the process, many layout tests were
disabled, because the form controls have a different appearance with
the feature enabled. This is one of several patches rebaselining those
disabled tests.

SHERIFFS: If one of the tests touched in this CL becomes/is flaky,
*please* add it to TestExpectations beneath the section for bug
1035582, and mark it with a *new* bug number. At this point, any
further failing tests are flaky on their own, not because of this
rebaseline. Thanks!

[1] http://crrev.com/c/1967608

Bug: 1035582
Change-Id: Icf39d2aca9cf8c3d12c3f4e0709e3601ef30a014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008353
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734074}
parent 30195a3b
......@@ -1755,9 +1755,6 @@ crbug.com/987224 [ IOS ] virtual/cascade/external/wpt/css/css-paint-api/idlharne
# PLEASE DO NOT PUT ANYTHING INSIDE THIS SECTION!!
# ======
# These need further investigation (baselines look broken):
crbug.com/1035582 virtual/form-controls-refresh-disabled/fast/forms/select/menulist-update-text-popup.html [ Skip ]
crbug.com/1035582 fast/forms/calendar-picker/calendar-picker-key-operations.html [ Skip ]
# Put back the one on 4788:
crbug.com/1035582 fast/forms/suggested-value.html [ Skip ]
crbug.com/1035582 fast/forms/select/listbox-tap.html [ Skip ]
......@@ -1773,23 +1770,17 @@ crbug.com/1035582 fast/forms/button/button-with-float.html [ Skip ]
crbug.com/1035582 fast/forms/select/listbox-overlay-scrollbar.html [ Skip ]
crbug.com/1035582 paint/invalidation/scroll/caret-with-composited-scroll.html [ Skip ]
crbug.com/1035582 paint/pagination/composited-paginated-outlined-box.html [ Skip ]
# https://test-results.appspot.com/data/layout_results/win10-blink-rel/6784/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
crbug.com/1035582 virtual/cascade/fast/forms/month/month-appearance-basic.html [ Skip ]
# https://test-results.appspot.com/data/layout_results/win7-blink-rel/6571/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
crbug.com/1035582 paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown.html [ Skip ]
crbug.com/1035582 paint/invalidation/forms/radio-focus-by-mouse-then-keydown.html [ Skip ]
# Need rebaseline again??
crbug.com/1035582 [ Win ] editing/caret/caret-position.html [ Skip ]
crbug.com/1035582 [ Win ] editing/pasteboard/4806874.html [ Skip ]
crbug.com/1035582 [ Win ] fast/forms/color/color-suggestion-picker-appearance-zoom125.html [ Skip ]
crbug.com/1035582 [ Win ] fast/multicol/multicol-with-child-renderLayer-for-input.html [ Skip ]
crbug.com/1035582 [ Win ] virtual/text-antialias/selection/mixed-directionality-selection.html [ Skip ]
# https://ci.chromium.org/p/chromium/builders/try/win7-blink-rel/6652
crbug.com/1035582 [ Win7 ] fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html [ Skip ]
crbug.com/1035582 [ Win7 ] fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html [ Skip ]
# ======
# ====== End of rebaselines for crbug.com/1035582 ======
# ======
#
# PLEASE put new 1035582-related files below this line (AND NOT ABOVE IT!!)...
# PLEASE put new form controls refresh failures BELOW THIS LINE, and CREATE A NEW BUG NUMBER.
#
crbug.com/1035582 [ Mac10.10 ] virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/select/select-multiple-hover-focused-unselected.html [ Skip ]
crbug.com/1035582 [ Mac10.10 ] virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/select/select-multiple-appearance-basic.html [ Skip ]
......
......@@ -8,7 +8,7 @@
"paintInvalidations": [
{
"object": "LayoutButton BUTTON",
"rect": [4, 4, 58, 30],
"rect": [6, 6, 54, 26],
"reason": "subtree"
},
{
......
{
"layers": [
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF",
"paintInvalidations": [
{
"object": "LayoutNGBlockFlow INPUT",
"rect": [9, 7, 21, 21],
"reason": "subtree"
}
]
}
]
}
Tests <select> text update when popup is visible and selectionIndex changes.
Needs run-layout-test.
A
B
C
layer at (0,0) size 31x20
LayoutNGBlockFlow (positioned) {DIV} at (8,50) size 31x20
LayoutMenuList {SELECT} at (0,0) size 31x20 [bgcolor=#DDDDDD] [border: (1px solid #A9A9A9)]
LayoutBlockFlow (anonymous) at (1,1) size 29x18
LayoutText (anonymous) at (4,1) size 9x16
text run at (4,1) width 9: "C"
LayoutText {#text} at (0,0) size 0x0
......@@ -8,7 +8,7 @@
"paintInvalidations": [
{
"object": "LayoutNGBlockFlow INPUT",
"rect": [11, 9, 17, 17],
"rect": [9, 7, 21, 21],
"reason": "subtree"
}
]
......
Tests <select> text update when popup is visible and selectionIndex changes.
Needs run-layout-test.
A
B
C
layer at (0,0) size 33x20
LayoutNGBlockFlow (positioned) {DIV} at (8,50) size 33x20
LayoutMenuList {SELECT} at (0,0) size 33x20 [bgcolor=#FFFFFF] [border: (1px solid #A9A9A9)]
LayoutBlockFlow (anonymous) at (1,1) size 31x18
LayoutText (anonymous) at (4,1) size 9x16
text run at (4,1) width 9: "C"
LayoutText {#text} at (0,0) size 0x0
CONSOLE ERROR: Feature policy violation: oversized-images is not allowed in this document.
CONSOLE ERROR: Feature policy violation: oversized-images is not allowed in this document.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment