Commit 1fa19c62 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

RubyNG: Do not apply atomic inline behavior to RubyRuns in line breaking

Bug: 1069817
Change-Id: I9d4966bcffeeffae8d457e01d070fc5c276259bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239779
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777280}
parent b791ea2a
...@@ -496,7 +496,7 @@ bool NGLineBreaker::ShouldForceCanBreakAfter( ...@@ -496,7 +496,7 @@ bool NGLineBreaker::ShouldForceCanBreakAfter(
// Except when sticky images quirk was applied. // Except when sticky images quirk was applied.
if (UNLIKELY(text[item->StartOffset()] == kNoBreakSpaceCharacter)) if (UNLIKELY(text[item->StartOffset()] == kNoBreakSpaceCharacter))
return false; return false;
return true; return !item->IsRubyRun();
} }
if (item->EndOffset() > item_result.EndOffset()) if (item->EndOffset() > item_result.EndOffset())
break; break;
...@@ -1419,6 +1419,9 @@ void NGLineBreaker::HandleAtomicInline( ...@@ -1419,6 +1419,9 @@ void NGLineBreaker::HandleAtomicInline(
position_ += item_result->inline_size; position_ += item_result->inline_size;
if (item.IsRubyRun()) { if (item.IsRubyRun()) {
// Overrides can_break_after.
ComputeCanBreakAfter(item_result, auto_wrap_, break_iterator_);
NGAnnotationOverhang overhang = GetOverhang(*item_result); NGAnnotationOverhang overhang = GetOverhang(*item_result);
if (overhang.end > LayoutUnit()) { if (overhang.end > LayoutUnit()) {
item_result->pending_end_overhang = overhang.end; item_result->pending_end_overhang = overhang.end;
......
...@@ -4750,9 +4750,7 @@ crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-enco ...@@ -4750,9 +4750,7 @@ crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-enco
crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/utf-16le.html?include=workers [ Timeout ] crbug.com/930297 external/wpt/html/infrastructure/urls/resolving-urls/query-encoding/utf-16le.html?include=workers [ Timeout ]
# RubyNG TODOs # RubyNG TODOs
crbug.com/1069817 external/wpt/css/css-ruby/line-break-around-ruby-001.html [ Failure ]
crbug.com/1069817 fast/ruby/float-overhang-from-ruby-text.html [ Failure ] crbug.com/1069817 fast/ruby/float-overhang-from-ruby-text.html [ Failure ]
crbug.com/1069817 fast/ruby/line-break-ruby.html [ Failure ]
crbug.com/1069817 fast/ruby/position-after.html [ Failure ] crbug.com/1069817 fast/ruby/position-after.html [ Failure ]
crbug.com/1069817 virtual/text-antialias/emphasis-avoid-ruby.html [ Failure ] crbug.com/1069817 virtual/text-antialias/emphasis-avoid-ruby.html [ Failure ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment