Commit 1fb10877 authored by Ionel Popescu's avatar Ionel Popescu Committed by Commit Bot

Enable eye dropper feature on Win and Mac.

This CL enables the eye dropper feature on Windows and Mac.

Bug: 992297
Change-Id: I3ebe0e8526fda49f7956af4e3fe8fd2ea5cdb73d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412598Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#814291}
parent b2d302e0
#<skip - crbug.com/992297: the accessibility tree is different on Linux>
rootWebArea
++genericContainer ignored
++++genericContainer
......@@ -11,7 +12,7 @@ rootWebArea
++++++++++++++++++++genericContainer
++++++++++++++++++++++slider horizontal name='Color well' roleDescription='Color well with two-dimensional slider for selecting saturation and lightness' value='X: 227, Y: 0' valueForRange=227.00 minValueForRange=0.00 maxValueForRange=32016.00
++++++++++++++++++++genericContainer
++++++++++++++++++++++genericContainer ignored invisible
++++++++++++++++++++++genericContainer
++++++++++++++++++++++genericContainer ignored invisible
++++++++++++++++++++++genericContainer
++++++++++++++++++++++++slider horizontal name='Hue slider' valueForRange=116.00 minValueForRange=0.00 maxValueForRange=129.00
......
......@@ -7,6 +7,7 @@ AXWebArea AXRoleDescription='HTML content'
++++++++++++AXSlider AXDescription='Color well' AXRoleDescription='Color well with two-dimensional slider for selecting saturation and lightness' AXValue=227
++++++++++AXGroup AXRoleDescription='group'
++++++++++++AXGroup AXRoleDescription='group'
++++++++++++AXGroup AXRoleDescription='group'
++++++++++++++AXSlider AXDescription='Hue slider' AXRoleDescription='slider' AXValue=116
++++++++++AXTextField AXDescription='Red channel' AXRoleDescription='text field' AXValue='255'
++++++++++AXTextField AXDescription='Green channel' AXRoleDescription='text field' AXValue='153'
......
......@@ -8,6 +8,7 @@ Document
++++++++++++++Slider Name='Color well' RangeValue.IsReadOnly=false RangeValue.LargeChange=0.00 RangeValue.SmallChange=0.00 RangeValue.Maximum=32016.00 RangeValue.Minimum=0.00 RangeValue.Value=227.00 Value.Value='X: 227, Y: 0'
++++++++++++Group IsControlElement=false
++++++++++++++Group
++++++++++++++Group
++++++++++++++++Slider Name='Hue slider' RangeValue.IsReadOnly=false RangeValue.LargeChange=0.00 RangeValue.SmallChange=0.00 RangeValue.Maximum=129.00 RangeValue.Minimum=0.00 RangeValue.Value=116.00 Value.Value='116'
++++++++++++Edit Name='Red channel' Value.Value='255'
++++++++++++Edit Name='Green channel' Value.Value='153'
......
......@@ -5,7 +5,8 @@ ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>'
++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0><obj1><obj2><obj3><obj4><obj5><obj6>'
++++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>'
++++++++++++ROLE_SYSTEM_SLIDER name='Color well' value='X: 227, Y: 0' FOCUSABLE IA2_STATE_HORIZONTAL localized_extended_role='Color well with two-dimensional slider for selecting saturation and lightness'
++++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>'
++++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0><obj1>'
++++++++++++IA2_ROLE_SECTION FOCUSABLE
++++++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>'
++++++++++++++ROLE_SYSTEM_SLIDER name='Hue slider' value='116' FOCUSABLE IA2_STATE_HORIZONTAL
++++++++++ROLE_SYSTEM_TEXT name='Red channel' value='255' FOCUSABLE ia2_hypertext='255'
......
Popup opened.
EYE-DROPPER
COLOR-SELECTION-RING
RVALUECONTAINER
GVALUECONTAINER
......@@ -7,6 +8,7 @@ FORMAT-TOGGLER
COLOR-SELECTION-RING
FORMAT-TOGGLER clicked. Active color format changed.
COLOR-SELECTION-RING
EYE-DROPPER
COLOR-SELECTION-RING
HVALUECONTAINER
SVALUECONTAINER
......@@ -14,6 +16,7 @@ LVALUECONTAINER
FORMAT-TOGGLER
FORMAT-TOGGLER clicked. Active color format changed.
COLOR-SELECTION-RING
EYE-DROPPER
COLOR-SELECTION-RING
HEXVALUECONTAINER
FORMAT-TOGGLER
......
Popup opened.
COLOR-SELECTION-RING
RVALUECONTAINER
GVALUECONTAINER
BVALUECONTAINER
FORMAT-TOGGLER
COLOR-SELECTION-RING
FORMAT-TOGGLER clicked. Active color format changed.
COLOR-SELECTION-RING
COLOR-SELECTION-RING
HVALUECONTAINER
SVALUECONTAINER
LVALUECONTAINER
FORMAT-TOGGLER
FORMAT-TOGGLER clicked. Active color format changed.
COLOR-SELECTION-RING
COLOR-SELECTION-RING
HEXVALUECONTAINER
FORMAT-TOGGLER
TEST COMPLETE
......@@ -157,9 +157,16 @@ bool IsForcedColorsEnabled() {
return forced_colors_enabled;
}
// Enables the eye-dropper in the refresh color-picker.
const base::Feature kEyeDropper{"EyeDropper",
base::FEATURE_DISABLED_BY_DEFAULT};
// Enables the eye-dropper in the refresh color-picker for Windows and Mac.
// This feature will be released for other platforms in later milestones.
const base::Feature kEyeDropper {
"EyeDropper",
#if defined(OS_WIN) || defined(OS_MAC)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
#endif
};
bool IsEyeDropperEnabled() {
return IsFormControlsRefreshEnabled() &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment