Commit 1fc3e54a authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

cbuiv: remove some TOOLKIT_VIEWS checks

TOOLKIT_VIEWS is always defined when building //cbui/views, so these are
dead code.

Bug: None
Change-Id: Id22b091c647c754c52077efbfa0a91da61aa9043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199317Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768756}
parent 692d5214
...@@ -49,7 +49,6 @@ bool BrowserActionDragData::IsFromProfile(const Profile* profile) const { ...@@ -49,7 +49,6 @@ bool BrowserActionDragData::IsFromProfile(const Profile* profile) const {
return profile_ == profile; return profile_ == profile;
} }
#if defined(TOOLKIT_VIEWS)
void BrowserActionDragData::Write( void BrowserActionDragData::Write(
Profile* profile, ui::OSExchangeData* data) const { Profile* profile, ui::OSExchangeData* data) const {
DCHECK(data); DCHECK(data);
...@@ -80,7 +79,6 @@ BrowserActionDragData::GetBrowserActionFormatType() { ...@@ -80,7 +79,6 @@ BrowserActionDragData::GetBrowserActionFormatType() {
return *format; return *format;
} }
#endif
void BrowserActionDragData::WriteToPickle(Profile* profile, void BrowserActionDragData::WriteToPickle(Profile* profile,
base::Pickle* pickle) const { base::Pickle* pickle) const {
......
...@@ -10,10 +10,7 @@ ...@@ -10,10 +10,7 @@
#include <string> #include <string>
#include "base/macros.h" #include "base/macros.h"
#if defined(TOOLKIT_VIEWS)
#include "ui/base/dragdrop/os_exchange_data.h" #include "ui/base/dragdrop/os_exchange_data.h"
#endif
class Profile; class Profile;
...@@ -40,7 +37,7 @@ class BrowserActionDragData { ...@@ -40,7 +37,7 @@ class BrowserActionDragData {
// Returns true if this data is from the specified profile. // Returns true if this data is from the specified profile.
bool IsFromProfile(const Profile* profile) const; bool IsFromProfile(const Profile* profile) const;
#if defined(TOOLKIT_VIEWS) // Write data, attributed to the specified profile, to the clipboard.
void Write(Profile* profile, ui::OSExchangeData* data) const; void Write(Profile* profile, ui::OSExchangeData* data) const;
// Restores this data from the clipboard, returning true on success. // Restores this data from the clipboard, returning true on success.
...@@ -48,7 +45,6 @@ class BrowserActionDragData { ...@@ -48,7 +45,6 @@ class BrowserActionDragData {
// Returns the ClipboardFormatType this class supports (for Browser Actions). // Returns the ClipboardFormatType this class supports (for Browser Actions).
static const ui::ClipboardFormatType& GetBrowserActionFormatType(); static const ui::ClipboardFormatType& GetBrowserActionFormatType();
#endif
private: private:
void WriteToPickle(Profile* profile, base::Pickle* pickle) const; void WriteToPickle(Profile* profile, base::Pickle* pickle) const;
......
...@@ -527,13 +527,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageTest, PrepopulateRespectBlank) { ...@@ -527,13 +527,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageTest, PrepopulateRespectBlank) {
// Flaky on Win. http://crbug.com/92467 // Flaky on Win. http://crbug.com/92467
// Flaky on ChromeOS. http://crbug.com/118216 // Flaky on ChromeOS. http://crbug.com/118216
// Flaky on linux aura. http://crbug.com/163931 // Flaky on linux aura. http://crbug.com/163931
#if defined(TOOLKIT_VIEWS) IN_PROC_BROWSER_TEST_F(FindInPageTest, DISABLED_PasteWithoutTextChange) {
#define MAYBE_PasteWithoutTextChange DISABLED_PasteWithoutTextChange
#else
#define MAYBE_PasteWithoutTextChange PasteWithoutTextChange
#endif
IN_PROC_BROWSER_TEST_F(FindInPageTest, MAYBE_PasteWithoutTextChange) {
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
// Make sure Chrome is in the foreground, otherwise sending input // Make sure Chrome is in the foreground, otherwise sending input
......
...@@ -2,10 +2,6 @@ ...@@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// This functionality currently works on Windows and on Linux when
// toolkit_views is defined (i.e. for Chrome OS). It's not needed
// on the Mac, and it's not yet implemented on Linux.
#include "base/location.h" #include "base/location.h"
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "base/run_loop.h" #include "base/run_loop.h"
......
...@@ -299,7 +299,6 @@ class PageInfoBubbleViewBrowserTest : public DialogBrowserTest { ...@@ -299,7 +299,6 @@ class PageInfoBubbleViewBrowserTest : public DialogBrowserTest {
bool VerifyUi() override { bool VerifyUi() override {
if (!DialogBrowserTest::VerifyUi()) if (!DialogBrowserTest::VerifyUi())
return false; return false;
#if defined(TOOLKIT_VIEWS)
// Check that each expected View is present in the Page Info bubble. // Check that each expected View is present in the Page Info bubble.
views::View* page_info_bubble_view = views::View* page_info_bubble_view =
PageInfoBubbleView::GetPageInfoBubbleForTesting()->GetContentsView(); PageInfoBubbleView::GetPageInfoBubbleForTesting()->GetContentsView();
...@@ -309,10 +308,6 @@ class PageInfoBubbleViewBrowserTest : public DialogBrowserTest { ...@@ -309,10 +308,6 @@ class PageInfoBubbleViewBrowserTest : public DialogBrowserTest {
return false; return false;
} }
return true; return true;
#else
NOTIMPLEMENTED();
return false;
#endif
} }
protected: protected:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment