Skip to content

GitLab

T
tangled
Commit 1ffc37e9 authored by Mei Liang's avatar Mei Liang Committed by Commit Bot
Browse files
Options

[CloseSuggestion] Add accessibility strings 

This CL adds accessiblity strings for closing suggestion. In addition,
it updates description for other closing suggestion related strings.

Change-Id: Ie3c87ae4b91273a818b8b8950e59ca7b9c284709
Bug: 1004570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935045
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721068}
parent 958d5603
Hide whitespace changes
Inline Side-by-side
Showing with 28 additions and 4 deletions
build/android/lint/suppressions.xml
View file @ 1ffc37e9
......@@ -353,7 +353,11 @@ Still reading?
<ignore regexp="The resource `R.string.search_widget_title.*` appears to be unused"/>
<!-- crbug.com/1017492 remove this line and the following line after the bug is resolved -->
<ignore regexp="The resource `R.string.tab_grid_dialog_toolbar_share_group` appears to be unused"/>
<!-- crbug.com/1004570 remove this line and the following three lines after the bug resolved -->
<!-- crbug.com/1004570 remove this line and the following seven lines after the bug resolved -->
<ignore regexp="The resource `R.string.accessibility_tab_suggestion_review_button` appears to be unused"/>
<ignore regexp="The resource `R.string.accessibility_tab_suggestion_close_stale_message` appears to be unused"/>
<ignore regexp="The resource `R.string.accessibility_tab_suggestion_dismiss_button` appears to be unused"/>
<ignore regexp="The resource `R.plurals.accessibility_tab_suggestion_close_tab_action_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_stale_message` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_close_tab_action_button` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_suggestion_review_button` appears to be unused"/>
......
chrome/android/features/tab_ui/java/strings/android_chrome_tab_ui_strings.grd
View file @ 1ffc37e9
......@@ -228,15 +228,31 @@
</message>
<!-- Tab Suggestion strings -->
<message name="IDS_TAB_SUGGESTION_REVIEW_BUTTON" desc="This text button shows on the TabSuggestion card. When user clicks this text button, user will enter a selection mode where they can view all the suggested tabs and the rest of the open tabs.">
<message name="IDS_TAB_SUGGESTION_REVIEW_BUTTON" desc="This text button shows next the message 'X of your tabs haven't been used lately. Close them?'. When a user clicks this 'Review' text button, they will enter a selection mode where they can see the suggested tabs to close, see the rest of their open tabs, and choose what tabs to close.">
Review
</message>
<message name="IDS_TAB_SUGGESTION_CLOSE_TAB_ACTION_BUTTON" desc="This text button shows on the toolbar of the selection mode. When user clicks this text button, all the selected tabs will be closed">
<message name="IDS_TAB_SUGGESTION_CLOSE_TAB_ACTION_BUTTON" desc="When a user chooses to review suggested tabs to close, they enter a section mode to review and close the tabs. In that selection mode, this text button in the toolbar lets the user finalize their choices. When this button is tapped, all the selected tabs will be closed.">
Close
</message>
<message name="IDS_TAB_SUGGESTION_CLOSE_STALE_MESSAGE" desc="This text shows on the TabSuggestion card. It describes the TabSuggestion.">
<message name="IDS_TAB_SUGGESTION_CLOSE_STALE_MESSAGE" desc="On Chrome mobile, this text shows as a suggestion under a user's tabs. The suggestion prompts the user to automatically close some tabs that haven't been used lately. The placeholder denotes the number of suggested tabs to close, which will always be 2 or more (so 'tabs' should be plural).">
<ph name="NUMBER_OF_TABS">%1$s<ex>2</ex></ph> of your tabs haven't been used lately. Close them?
</message>
<!-- Accessibility strings for Tab Suggestion -->
<message name="IDS_ACCESSIBILITY_TAB_SUGGESTION_REVIEW_BUTTON" desc="The accessibility text to read when the text button 'Review' is focused. The 'Review' button is shown next to the message 'X of your tabs haven't been used lately. Close them?'. User uses that text button to enter a selection mode where they can see the suggested tabs to close, see the rest of their open tabs, and choose what tabs to close.">
Review the suggestions.
</message>
<message name="IDS_ACCESSIBILITY_TAB_SUGGESTION_CLOSE_STALE_MESSAGE" desc="The accessibility text to read when the TAB_SUGGESTION card is focused">
Suggestion: <ph name="NUMBER_OF_TABS">%1$s<ex>2</ex></ph> of your tabs haven't been used lately. Close them?
</message>
<message name="IDS_ACCESSIBILITY_TAB_SUGGESTION_DISMISS_BUTTON" desc="The accessibility text to read when the 'X' button on the TAB_SUGGESTION card is focused">
Dismiss the suggestions.
</message>
<message name="IDS_ACCESSIBILITY_TAB_SUGGESTION_CLOSE_TAB_ACTION_BUTTON" desc="The accessibility text to read when the 'Close' text button in the selection mode toolbar is focused. When this button is tapped, all the selected tabs will be closed.">
{TABS_COUNT, plural,
=1 {Close <ph name="TABS_COUNT_ONE">%1$d<ex>1</ex></ph> selected tab}
other {Close <ph name="TABS_COUNT_MANY">%1$d<ex>8</ex></ph> selected tabs}
}
</message>
</messages>
</release>
</grit>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment