DL: Fix flaky getFullAXTree & wrongly updated accessibility tests

A devtoools display locking a11y test was marked as failing in MSAN bots
and is also flaky when tested locally, this CL updates that test and
fixes the cause of the failure (getFullAXTree might be called when
style/layout is dirty, which caused failing DCHECKs).

Some other display locking a11y tests were not updated correctly, and is
updated in this CL as well.

Bug: 996625
Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706834}

content/test/data/accessibility/display-locking/activatable-activated.html

@@ -2,9 +2,9 @@
 @BLINK-ALLOW:offscreen
 -->
 <div>
-  <div id="locked" rendersubtree="invisible">
+  <div id="locked" rendersubtree="invisible skip-viewport-activation">
     <div>child</div>
-    <div id="nested" rendersubtree="invisible">nested locked element!</div>
+    <div id="nested" rendersubtree="invisible skip-viewport-activation">nested locked element!</div>
     <div id="nonActivatable" rendersubtree="invisible skip-activation">nested non activatable locked element</div>
   </div>
 </div>

content/test/data/accessibility/display-locking/activatable.html

@@ -2,9 +2,9 @@
 @BLINK-ALLOW:offscreen
 -->
 <div>
-  <div id="locked" rendersubtree="invisible">
+  <div id="locked" rendersubtree="invisible skip-viewport-activation">
     <div>child</div>
-    <div id="nested" rendersubtree="invisible">nested locked element!</div>
+    <div id="nested" rendersubtree="invisible skip-viewport-activation">nested locked element!</div>
     <div id="nonActivatable" rendersubtree="invisible skip-activation">nested non activatable locked element</div>
   </div>
 </div>

content/test/data/accessibility/display-locking/all-committed.html

@@ -2,9 +2,9 @@
 @BLINK-ALLOW:offscreen
 -->
 <div>
-  <div id="locked" rendersubtree="invisible skip-activation">
+  <div id="locked" rendersubtree="invisible skip-viewport-activation">
     <div>child</div>
-    <div id="nested" rendersubtree="invisible skip-activation">nested locked element!</div>
+    <div id="nested" rendersubtree="invisible skip-viewport-activation">nested locked element!</div>
     <div id="nonActivatable" rendersubtree="invisible skip-activation">nested non activatable locked element</div>
     <!--
       TODO(rakina): Make display:none, visibility:hidden, aria-hidden nodes

content/test/data/accessibility/display-locking/all.html

@@ -2,9 +2,9 @@
 @BLINK-ALLOW:offscreen
 -->
 <div>
-  <div id="locked" rendersubtree="invisible">
+  <div id="locked" rendersubtree="invisible skip-viewport-activation">
     <div>child</div>
-    <div id="nested" rendersubtree="invisible">nested locked element!</div>
+    <div id="nested" rendersubtree="invisible skip-viewport-activation">nested locked element!</div>
     <div id="nonActivatable" rendersubtree="invisible skip-activation">nested non activatable locked element</div>
     <!--
       TODO(rakina): Make display:none, visibility:hidden, aria-hidden nodes

content/test/data/accessibility/display-locking/non-activatable.html

@@ -5,6 +5,6 @@
   <div id="locked" rendersubtree="invisible skip-activation">
     <div>child</div>
     <div id="nested" rendersubtree="invisible skip-activation">nested locked element!</div>
-    <div id="activatable" rendersubtree="invisible skip-activation">non activatable locked element</div>
+    <div id="activatable" rendersubtree="invisible skip-viewport-activation">activatable locked element</div>
   </div>
 </div>

third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc

@@ -11,6 +11,7 @@
 #include "third_party/blink/renderer/core/dom/flat_tree_traversal.h"
 #include "third_party/blink/renderer/core/dom/node.h"
 #include "third_party/blink/renderer/core/dom/node_list.h"
+#include "third_party/blink/renderer/core/dom/text.h"
 #include "third_party/blink/renderer/core/frame/local_frame.h"
 #include "third_party/blink/renderer/core/html_names.h"
 #include "third_party/blink/renderer/core/inspector/identifiers_factory.h"
@@ -724,6 +725,8 @@ Response InspectorAccessibilityAgent::getFullAXTree(
   Document* document = inspected_frames_->Root()->GetDocument();
   if (!document)
     return Response::Error("No document.");
+  if (document->View()->NeedsLayout() || document->NeedsLayoutTreeUpdate())
+    document->UpdateStyleAndLayout();
   *nodes = std::make_unique<protocol::Array<protocol::Accessibility::AXNode>>();
   AXContext ax_context(*document);
   AXObjectCacheImpl& cache = ToAXObjectCacheImpl(ax_context.GetAXObjectCache());

third_party/blink/web_tests/TestExpectations

@@ -260,9 +260,6 @@ crbug.com/1004650 http/tests/security/contentSecurityPolicy/frame-src-cross-orig
 
 # Display locking failures
 
-# MSAN failure
-crbug.com/996625 inspector-protocol/accessibility/accessibility-getFullAXTree-display-locked.js [ Skip ]
-
 crbug.com/849459 fragmentation/repeating-thead-under-repeating-thead.html [ Failure ]
 
 # These tests are no longer applicable in BlinkGenPropertyTree mode.

third_party/blink/web_tests/inspector-protocol/accessibility/accessibility-getFullAXTree-display-locked.js

 (async function(testRunner) {
   var {page, session, dp} = await testRunner.startHTML(`
-    <div id='activatable' rendersubtree='invisible-activatable'>
+    <div id='activatable' rendersubtree='invisible skip-viewport-activation'>
       locked
       <div id='child'>
         child
         <div id='grandChild'>grandChild</div>
       </div>
       <div id='invisible' style='display:none'>invisible</div>
-      <div id='nested' rendersubtree='invisible-activatable'>nested</div>
+      <div id='nested' rendersubtree='invisible skip-viewport-activation'>nested</div>
       text
     </div>
-    <div id='nonActivatable' rendersubtree='invisible'>nonActivatable text</div>
+    <div id='nonActivatable' rendersubtree='invisible skip-activation'>nonActivatable text</div>
     <div id='normal'>normal text</div>
-    <script>
-      activatable.getBoundingClientRect(); // Force layout
-    </script>
   `, 'Tests accessibility values of display locked nodes');
   const dumpAccessibilityNodesFromList =
       (await testRunner.loadScript('../resources/accessibility-dumpAccessibilityNodesFromList.js'))(testRunner, session);