Commit 2013046d authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

Bookmarks WebUI: announce when search is cleared

Bug: 854673
Change-Id: I139764a243ebf1d6c4209e124e6a8cf328985053
Reviewed-on: https://chromium-review.googlesource.com/c/1299835Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607808}
parent 510fbfcb
...@@ -332,6 +332,9 @@ are declared in tools/grit/grit_rule.gni. ...@@ -332,6 +332,9 @@ are declared in tools/grit/grit_rule.gni.
</message> </message>
<!-- Search strings are only used in webui, so no mobile. --> <!-- Search strings are only used in webui, so no mobile. -->
<if expr="not is_android"> <if expr="not is_android">
<message name="IDS_SEARCH_CLEARED" desc="Message announced to screenreader users when search is cleared.">
Search cleared
</message>
<message name="IDS_SEARCH_RESULTS" desc="Message announced to screenreader users when searching completes and results are showing."> <message name="IDS_SEARCH_RESULTS" desc="Message announced to screenreader users when searching completes and results are showing.">
Search results for '<ph name="SEARCH_TEXT">$1<ex>cookies</ex></ph>' Search results for '<ph name="SEARCH_TEXT">$1<ex>cookies</ex></ph>'
</message> </message>
......
...@@ -115,7 +115,12 @@ Polymer({ ...@@ -115,7 +115,12 @@ Polymer({
}, },
/** @private */ /** @private */
searchTermChanged_: function() { searchTermChanged_: function(newValue, oldValue) {
if (oldValue != undefined && !newValue) {
this.fire(
'iron-announce', {text: loadTimeData.getString('searchCleared')});
}
if (!this.searchTerm_) if (!this.searchTerm_)
return; return;
......
...@@ -127,6 +127,7 @@ content::WebUIDataSource* CreateMdBookmarksUIHTMLSource(Profile* profile) { ...@@ -127,6 +127,7 @@ content::WebUIDataSource* CreateMdBookmarksUIHTMLSource(Profile* profile) {
IDS_MD_BOOKMARK_MANAGER_SIDEBAR_NODE_COLLAPSE_AX_LABEL); IDS_MD_BOOKMARK_MANAGER_SIDEBAR_NODE_COLLAPSE_AX_LABEL);
AddLocalizedString(source, "sidebarNodeExpandAxLabel", AddLocalizedString(source, "sidebarNodeExpandAxLabel",
IDS_MD_BOOKMARK_MANAGER_SIDEBAR_NODE_EXPAND_AX_LABEL); IDS_MD_BOOKMARK_MANAGER_SIDEBAR_NODE_EXPAND_AX_LABEL);
AddLocalizedString(source, "searchCleared", IDS_SEARCH_CLEARED);
AddLocalizedString(source, "searchResults", IDS_SEARCH_RESULTS); AddLocalizedString(source, "searchResults", IDS_SEARCH_RESULTS);
AddLocalizedString(source, "saveEdit", IDS_SAVE); AddLocalizedString(source, "saveEdit", IDS_SAVE);
AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE); AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment