Remove Clear Browsing Data preferences from incognito whitelist.

Clear browsing data preferences (browsing_data::prefs::*) are removed
from incognito whitelist for persistent storage.
The browsing_data preferences are used by Clear Browsing Data, which
is only available in regular mode.

Bug: 861722
Change-Id: I7835f8b1ad2a8b4a8b7bb72b99401b281823f313
Reviewed-on: https://chromium-review.googlesource.com/1141565
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576375}

chrome/browser/prefs/pref_service_incognito_whitelist.cc

@@ -9,7 +9,6 @@
 #include "chrome/common/pref_names.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/bookmarks/common/bookmark_pref_names.h"
-#include "components/browsing_data/core/pref_names.h"
 #include "components/certificate_transparency/pref_names.h"
 #include "components/component_updater/pref_names.h"
 #include "components/consent_auditor/pref_names.h"
@@ -918,25 +917,6 @@ const char* incognito_whitelist[] = {
     bookmarks::prefs::kShowManagedBookmarksInBookmarkBar,
     bookmarks::prefs::kShowBookmarkBar,
 
-    // components/browsing_data/core/pref_names.h
-    browsing_data::prefs::kDeleteTimePeriod,
-    browsing_data::prefs::kDeleteTimePeriodBasic,
-    browsing_data::prefs::kDeleteBrowsingHistory,
-    browsing_data::prefs::kDeleteBrowsingHistoryBasic,
-    browsing_data::prefs::kDeleteDownloadHistory,
-    browsing_data::prefs::kDeleteCache, browsing_data::prefs::kDeleteCacheBasic,
-    browsing_data::prefs::kDeleteCookies,
-    browsing_data::prefs::kDeleteCookiesBasic,
-    browsing_data::prefs::kDeletePasswords,
-    browsing_data::prefs::kDeleteFormData,
-    browsing_data::prefs::kDeleteHostedAppsData,
-    browsing_data::prefs::kDeleteMediaLicenses,
-    browsing_data::prefs::kDeleteSiteSettings,
-    browsing_data::prefs::kLastClearBrowsingDataTime,
-    browsing_data::prefs::kClearBrowsingDataHistoryNoticeShownTimes,
-    browsing_data::prefs::kLastClearBrowsingDataTab,
-    browsing_data::prefs::kPreferencesMigratedToBasic,
-
     // components/certificate_transparency/pref_names.h
     certificate_transparency::prefs::kCTRequiredHosts,
     certificate_transparency::prefs::kCTExcludedHosts,

chrome/browser/prefs/pref_service_syncable_util.cc

@@ -34,7 +34,7 @@ CreateIncognitoPrefServiceSyncable(
 
   // TODO(https://crbug.com/861722): Remove |GetIncognitoWhitelist| and its
   // file. This list is ONLY added for transition of code from blacklist to
-  // whitelist. All whitelisted prefs can be added here to
+  // whitelist. All whitelisted prefs should be added here to
   // |persistent_pref_names|.
   prefs::GetIncognitoWhitelist(&persistent_pref_names);