Dynamically update sign-in/Sync status in the profile creation overlay.

BUG=269006

Review URL: https://chromiumcodereview.appspot.com/22751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217082 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/resources/options/manage_profile_overlay.js

@@ -617,8 +617,13 @@ cr.define('options', function() {
       var isSignedIn = email !== '';
       $('create-profile-managed-signed-in').hidden = !isSignedIn;
       $('create-profile-managed-not-signed-in').hidden = isSignedIn;
-      $('select-existing-managed-profile-checkbox').hidden = !isSignedIn;
-      $('choose-existing-managed-profile').hidden = !isSignedIn;
+      var hideSelectExistingManagedUsers =
+          !isSignedIn ||
+          !loadTimeData.getBoolean('allowCreateExistingManagedUsers');
+      $('select-existing-managed-profile-checkbox').hidden =
+          hideSelectExistingManagedUsers;
+      $('choose-existing-managed-profile').hidden =
+          hideSelectExistingManagedUsers;
 
       if (isSignedIn) {
         var accountDetailsOutOfDate =

chrome/browser/ui/webui/options/manage_profile_handler.cc

@@ -82,6 +82,11 @@ ManageProfileHandler::ManageProfileHandler()
 }
 
 ManageProfileHandler::~ManageProfileHandler() {
+  ProfileSyncService* service =
+      ProfileSyncServiceFactory::GetForProfile(Profile::FromWebUI(web_ui()));
+  // Sync may be disabled in tests.
+  if (service)
+    service->RemoveObserver(this);
 }
 
 void ManageProfileHandler::GetLocalizedValues(
@@ -140,11 +145,17 @@ void ManageProfileHandler::InitializeHandler() {
   registrar_.Add(this, chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED,
                  content::NotificationService::AllSources());
 
-  pref_change_registrar_.Init(Profile::FromWebUI(web_ui())->GetPrefs());
+  Profile* profile = Profile::FromWebUI(web_ui());
+  pref_change_registrar_.Init(profile->GetPrefs());
   pref_change_registrar_.Add(
       prefs::kManagedUserCreationAllowed,
       base::Bind(&ManageProfileHandler::OnCreateManagedUserPrefChange,
                  base::Unretained(this)));
+  ProfileSyncService* service =
+      ProfileSyncServiceFactory::GetForProfile(profile);
+  // Sync may be disabled for tests.
+  if (service)
+    service->AddObserver(this);
 }
 
 void ManageProfileHandler::InitializePage() {
@@ -206,6 +217,10 @@ void ManageProfileHandler::Observe(
   }
 }
 
+void ManageProfileHandler::OnStateChanged() {
+  RequestCreateProfileUpdate(NULL);
+}
+
 void ManageProfileHandler::RequestDefaultProfileIcons(const ListValue* args) {
   base::StringValue create_value(kCreateProfileIconGridName);
   base::StringValue manage_value(kManageProfileIconGridName);

chrome/browser/ui/webui/options/manage_profile_handler.h

@@ -9,6 +9,7 @@
 
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_change_registrar.h"
+#include "chrome/browser/sync/profile_sync_service_observer.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 namespace base {
@@ -18,7 +19,8 @@ class StringValue;
 namespace options {
 
 // Chrome personal stuff profiles manage overlay UI handler.
-class ManageProfileHandler : public OptionsPageUIHandler {
+class ManageProfileHandler : public OptionsPageUIHandler,
+                             public ProfileSyncServiceObserver {
  public:
   ManageProfileHandler();
   virtual ~ManageProfileHandler();
@@ -37,6 +39,9 @@ class ManageProfileHandler : public OptionsPageUIHandler {
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
+  // ProfileSyncServiceObserver:
+  virtual void OnStateChanged() OVERRIDE;
+
  private:
   // Callback for the "requestDefaultProfileIcons" message.
   // Sends the array of default profile icon URLs to WebUI.