Commit 204762c9 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/rlz

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: Id1340e7ec64d65905152a1588fbda307fa38f884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410237Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806647}
parent fcd0f0a1
...@@ -2,17 +2,35 @@ ...@@ -2,17 +2,35 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("rlz") { static_library("rlz") {
sources = [ sources = [
"rlz_tracker.cc", "rlz_tracker.cc",
"rlz_tracker.h", "rlz_tracker.h",
"rlz_tracker_chromeos.cc",
"rlz_tracker_delegate.h", "rlz_tracker_delegate.h",
"rlz_tracker_ios.cc",
"rlz_tracker_mac.cc",
"rlz_tracker_win.cc",
] ]
if (is_ios) {
sources += [ "rlz_tracker_ios.cc" ]
}
if (is_mac) {
sources += [ "rlz_tracker_mac.cc" ]
}
if (is_win) {
sources += [ "rlz_tracker_win.cc" ]
}
if (is_chromeos) {
sources += [ "rlz_tracker_chromeos.cc" ]
}
deps = [ deps = [
"//base", "//base",
"//components/google/core/common", "//components/google/core/common",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment