[Passwords] Add 'Hide Password' string and remove show password functionality

This change adds a string for "Hide Password" which is supposed to be
used in the more actions menu in the Password Check page. Furthermore,
this change removes the "Show Password" menu entry for now, as there is
no functionality.

Bug: 1047726
Change-Id: I0f96d1794715b97754b9d3141dd75c3b0534149e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100748
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749722}

chrome/app/settings_strings.grdp

@@ -407,6 +407,9 @@
   <message name="IDS_SETTINGS_COMPROMISED_PASSWORD_SHOW" desc="Action menu item for a row which displays a compromised password. The password value, which is initialy obfuscated, will be show in plain text.">
     Show password
   </message>
+  <message name="IDS_SETTINGS_COMPROMISED_PASSWORD_HIDE" desc="Action menu item for a row which displays a compromised password. The password value, which is shown in plain text, will be hidden again.">
+    Hide password
+  </message>
   <message name="IDS_SETTINGS_COMPROMISED_PASSWORD_EDIT" desc="Action menu item for a row which displays a compromised password. It will open a modal dialog which will allow the user to edit the password and other metadata (username, website).">
     Edit password
   </message>

chrome/app/settings_strings_grdp/IDS_SETTINGS_COMPROMISED_PASSWORD_HIDE.png.sha1

+07f9122e0d93c125efe2bdc2861aaa8d4f0297ac
\ No newline at end of file

chrome/browser/resources/settings/autofill_page/password_check.html

@@ -124,10 +124,7 @@
       </div>
     </div>
     <cr-action-menu id="moreActionsMenu" role-description="$i18n{menu}">
-      <button id="menuShowPassword" class="dropdown-item"
-          on-click="onMenuShowPasswordClick_">
-        $i18n{showCompromisedPassword}
-      </button>
+      <!-- TODO(crbug.com/1047726) Add show / hide functionality -->
       <button id="menuEditPassword" class="dropdown-item"
           on-click="onMenuEditPasswordClick_">
         $i18n{editCompromisedPassword}

chrome/browser/resources/settings/autofill_page/password_check.js

@@ -185,13 +185,6 @@ Polymer({
     this.activeDialogAnchor_ = target;
   },
 
-  /** @private */
-  onMenuShowPasswordClick_() {
-    this.$.moreActionsMenu.close();
-
-    // TODO(crbug.com/1047726) Implement dialog.
-  },
-
   /** @private */
   onMenuEditPasswordClick_() {
     this.$.moreActionsMenu.close();

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -764,6 +764,7 @@ void AddAutofillStrings(content::WebUIDataSource* html_source,
       {"noCompromisedCredentials",
        IDS_SETTINGS_NO_COMPROMISED_CREDENTIALS_LABEL},
       {"showCompromisedPassword", IDS_SETTINGS_COMPROMISED_PASSWORD_SHOW},
+      {"hideCompromisedPassword", IDS_SETTINGS_COMPROMISED_PASSWORD_HIDE},
       {"editCompromisedPassword", IDS_SETTINGS_COMPROMISED_PASSWORD_EDIT},
       {"removeCompromisedPassword", IDS_SETTINGS_COMPROMISED_PASSWORD_REMOVE},
       {"removeCompromisedPasswordConfirmationTitle",